Re: [PATCH 13/13] rtems: Avoid potential recursion in ASR handling

2021-02-19 Thread Gedare Bloom
On Fri, Feb 19, 2021 at 9:35 AM Gedare Bloom wrote: > > On Thu, Feb 18, 2021 at 11:59 PM Sebastian Huber > wrote: > > > > On 18/02/2021 18:49, Gedare Bloom wrote: > > > > >> + executing->cpu_time_budget = normal_cpu_time_budget ; > > >> + executing->budget_algorithm = normal_budget_algorithm ;

Re: [PATCH 13/13] rtems: Avoid potential recursion in ASR handling

2021-02-19 Thread Gedare Bloom
On Thu, Feb 18, 2021 at 11:59 PM Sebastian Huber wrote: > > On 18/02/2021 18:49, Gedare Bloom wrote: > > >> + executing->cpu_time_budget = normal_cpu_time_budget ; > >> + executing->budget_algorithm = normal_budget_algorithm ; > >> + prev_is_preemptible = executing->is_preemptible; > > 'prev' i

Re: [PATCH 13/13] rtems: Avoid potential recursion in ASR handling

2021-02-18 Thread Sebastian Huber
On 18/02/2021 18:49, Gedare Bloom wrote: + executing->cpu_time_budget = normal_cpu_time_budget ; + executing->budget_algorithm = normal_budget_algorithm ; + prev_is_preemptible = executing->is_preemptible; 'prev' is unclear here, especially since we have "normal" as a previous mode also. May

Re: [PATCH 13/13] rtems: Avoid potential recursion in ASR handling

2021-02-18 Thread Peter Dufault
> On Feb 18, 2021, at 12:49 , Gedare Bloom wrote: > > willing to buy: style formatter. I'll buy one too. Peter - Peter Dufault HD Associates, Inc. Software and System Engineering This email is delivered through the public internet using protocols subject to interception

Re: [PATCH 13/13] rtems: Avoid potential recursion in ASR handling

2021-02-18 Thread Gedare Bloom
On Wed, Feb 17, 2021 at 12:30 PM Sebastian Huber wrote: > > Do the mode changes necessary for the ASR processing directly under > protection of the thread state lock to avoid the recursive calls to > thread dispatching done in rtems_task_mode(). > > Update #4244. > --- > cpukit/rtems/src/signalse