Re: [PATCH 0/1] grlib/genirq: Issue when enabling/disabling interrupt

2021-04-15 Thread Daniel Hellstrom
Hi Jan, I think it is a correct analysis of the bad return value, when using shared interrupt routines on the same interrupt source. I'm fine with the patch, maybe it could have been simplified, like this: +++ b/bsps/shared/grlib/irq/genirq.c @@ -188,8 +188,8 @@ static int genirq_set_active(

RE: [PATCH 0/1] grlib/genirq: Issue when enabling/disabling interrupt

2021-04-15 Thread Jan.Sommer
Does someone have any objections to this patch? I would like to push it to master and 5. Or should we reach out to someone at Gaisler to check if it is ok? Best regards, Jan > -Original Message- > From: devel On Behalf Of > gabriel.moy...@dlr.de > Sent: Tuesday, April 13, 2021 10:09

Re: [PATCH 0/1] grlib/genirq: Issue when enabling/disabling interrupt

2021-04-12 Thread Gedare Bloom
Is this a bug in rtems 5 also? If so, does it warrant a back-port fix and a ticket? On Mon, Apr 12, 2021 at 3:16 AM Moyano, Gabriel wrote: > > Hello everyone, > > I've found what can be an issue in the function genirq_set_active(): under > some conditions it can return a value greater than 1. >