Re: [PATCH] libmisc/shell: Add the rtrace command for buffered tracing support.

2015-03-29 Thread Chris Johns
On 30/03/2015 2:34 am, Gedare Bloom wrote: > Quick comments: Thanks for the review. > Avoid abbreviations but feel free to use acronyms in "rtems" APIs . RTEMS is also an abbreviation ;) These should really become rtems_trace_buffering_*. I will change. I do not want to change the internal gen

Re: [PATCH] libmisc/shell: Add the rtrace command for buffered tracing support.

2015-03-29 Thread Gedare Bloom
Quick comments: Avoid abbreviations but feel free to use acronyms in "rtems" APIs . Make sure acronyms are documented, what is TBG? If divide by 32 is on hot path might want to reconsider it if possible A macro for the bit masks would improve readability I've seen this print timestamp function