Re: [PATCH] libcsupport: Fix TOCTOU in getchark()

2021-07-28 Thread Sebastian Huber
On 28/07/2021 18:27, Joel Sherrill wrote: The commit message should explain that. I will try to improve the commit message. I don't see a CID for this one in the reports but someone should check that. I don't like their web interface and might have missed something. I noticed this while re

Re: [PATCH] libcsupport: Fix TOCTOU in getchark()

2021-07-28 Thread Joel Sherrill
On Wed, Jul 28, 2021 at 11:23 AM Gedare Bloom wrote: > > On Wed, Jul 28, 2021 at 9:13 AM Joel Sherrill wrote: > > > > Is this a Coverity issue? Does it have a CID? > > > > I remembered TOCTOU as an acronym analysis reports used > > but had to look up the meaning. I don't know what to do so someon

Re: [PATCH] libcsupport: Fix TOCTOU in getchark()

2021-07-28 Thread Gedare Bloom
On Wed, Jul 28, 2021 at 9:13 AM Joel Sherrill wrote: > > Is this a Coverity issue? Does it have a CID? > > I remembered TOCTOU as an acronym analysis reports used > but had to look up the meaning. I don't know what to do so someone > else would not have to look it up beyond explaining it in the lo

Re: [PATCH] libcsupport: Fix TOCTOU in getchark()

2021-07-28 Thread Joel Sherrill
Is this a Coverity issue? Does it have a CID? I remembered TOCTOU as an acronym analysis reports used but had to look up the meaning. I don't know what to do so someone else would not have to look it up beyond explaining it in the long comment. It is missing what was checked and used that flagged