Re: [PATCH] Port ndbm

2019-06-07 Thread Vaibhav Gupta
Okay! So first let me check what files are updated till now. On Sat, 8 Jun, 2019, 1:00 AM Gedare Bloom, wrote: > I wouldn't send the patch, I would suggest you write an email to > discuss about how you are porting ndbm, and that the current version > relies on the search/hash functions, and that

Re: [PATCH] Port ndbm

2019-06-07 Thread Gedare Bloom
I wouldn't send the patch, I would suggest you write an email to discuss about how you are porting ndbm, and that the current version relies on the search/hash functions, and that the interface has changed a bit over time so inquire whether you should update hash/search functions to newer versions.

Re: [PATCH] Port ndbm

2019-06-07 Thread Vaibhav Gupta
Sure! I will send the patch to newlib and ask them if they need updated set of files inside libc/search. On Fri, 7 Jun, 2019, 10:29 PM Gedare Bloom, wrote: > On Thu, Jun 6, 2019 at 8:02 PM Vaibhav Gupta > wrote: > > > > Please review the code so that I can send it to newlib-devel. > > > > On Fr

Re: [PATCH] Port ndbm

2019-06-07 Thread Gedare Bloom
On Thu, Jun 6, 2019 at 8:02 PM Vaibhav Gupta wrote: > > Please review the code so that I can send it to newlib-devel. > > On Fri, Jun 7, 2019 at 7:22 AM Vaibhav Gupta wrote: >> >> --- >> newlib/libc/include/ndbm.h| 86 ++ >> newlib/libc/posix/Makefile.am | 4 +- >> newlib/libc

Re: [PATCH] Port ndbm

2019-06-06 Thread Vaibhav Gupta
Please review the code so that I can send it to newlib-devel. On Fri, Jun 7, 2019 at 7:22 AM Vaibhav Gupta wrote: > --- > newlib/libc/include/ndbm.h| 86 ++ > newlib/libc/posix/Makefile.am | 4 +- > newlib/libc/posix/ndbm.c | 214 ++ > 3 f

Re: [PATCH] Port ndbm

2019-06-05 Thread Vaibhav Gupta
When I checked further, libc/posix/Makefile.am INCLUDES is the old name for AM_CPPFLAGS, hence I added the new path in it. . INCLUDES = $(NEWLIB_CFLAGS) $(CROSS_CFLAGS) $(TARGET_CFLAGS) -I$(top_srcdir)/search . . ___ devel mailing list devel@rtems.or