Re: [PATCH] Fixes GPIO APIs Naming Convention and Comments

2015-10-21 Thread Ben Gras
On Thu, Oct 15, 2015 at 12:02 AM, Gedare Bloom wrote: > A ticket would be preferred. I didn't notice the attachment. Can you > please (1) make a ticket, (2) close it in the commit message, and (3) > re-send your patch. > > Ben, if you get around to it, please commit the revised patch when it > com

Re: [PATCH] Fixes GPIO APIs Naming Convention and Comments

2015-10-14 Thread Gedare Bloom
A ticket would be preferred. I didn't notice the attachment. Can you please (1) make a ticket, (2) close it in the commit message, and (3) re-send your patch. Ben, if you get around to it, please commit the revised patch when it comes through. I'll be away for a few days and unable to commit. On

Re: [PATCH] Fixes GPIO APIs Naming Convention and Comments

2015-10-14 Thread sudarshan.rajagopalan
On 2015-10-14 16:28, Gedare Bloom wrote: OK to commit, but the patch did not apply cleanly for me, something wrong with the mail message. Hi Gedare, The mail message was not sent using git send-email (this is not working for us currently), so I copied the contents of the patch to this mail

Re: [PATCH] Fixes GPIO APIs Naming Convention and Comments

2015-10-14 Thread Gedare Bloom
OK to commit, but the patch did not apply cleanly for me, something wrong with the mail message. On Tue, Oct 13, 2015 at 3:11 AM, Ben Gras wrote: > All, > > This change renames these gpio-specific functions: > > rtems_bsp_enable_interrupt > rtems_bsp_disable_interrupt > rtems_bsp_select_specific_

Re: [PATCH] Fixes GPIO APIs Naming Convention and Comments

2015-10-13 Thread Ben Gras
All, This change renames these gpio-specific functions: rtems_bsp_enable_interrupt rtems_bsp_disable_interrupt rtems_bsp_select_specific_io to rtems_gpio_bsp_enable_interrupt rtems_gpio_bsp_disable_interrupt rtems_gpio_bsp_select_specific_io +1, Definitely an improvement. On Mon, Oct 12, 20

Re: [PATCH] Fixes GPIO APIs Naming Convention and Comments

2015-10-12 Thread sudarshan.rajagopalan
Sure, André. Me too released when I started working on the GPIO driver. Although, great work with the generic GPIO API implementation for RTEMS. :) Really like the way it uses chained linked list to call the user ISR when a gpio bank(or port) interrupt is generated. I do have few other questio

Re: [PATCH] Fixes GPIO APIs Naming Convention and Comments

2015-10-12 Thread André Marques
Hello Sudarshan, Às 18:37 de 12-10-2015, sudarshan.rajagopalan escreveu: Just found few function names to be inconsistent towards the naming convention, and also few API documentation in the RTEMS GPIO files. Please commit this if required. Thanks for the patch! I noticed that some function