This is the last discussion of the patch I could find. Have you made these
changes?
Also if it is going to go on the master, the waf build side needs updating.
For the near future, both build systems will be in place so we can ensure
the transition is smooth and doesn't introduce anything.
--joe
Review feedback should stay on the list. :)
On Sat, Sep 12, 2020 at 4:29 PM Eshan Dhawan
wrote:
>
>
>
> On Sat, Sep 12, 2020 at 2:45 AM Joel Sherrill wrote:
>
>> This looks close to me but I see some minor issues. I have tried to
>> annotate them.
>>
>> The spacing ones could be spaces vs tabs.
This looks close to me but I see some minor issues. I have tried to
annotate them.
The spacing ones could be spaces vs tabs. Not sure.
On Thu, Sep 10, 2020 at 3:48 PM Eshan dhawan
wrote:
> Adds Confstr file To RTEMS with test
>
> Signed-off-by: Eshan dhawan
> ---
> cpukit/Makefile.am
On Wed, Aug 19, 2020 at 7:05 PM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> On 19/08/2020 15:04, Eshan dhawan wrote:
>
> > diff --git a/testsuites/psxtests/psxconfstr/init.c
> b/testsuites/psxtests/psxconfstr/init.c
> > new file mode 100644
> > index 00..8660f04b29
> > -
On Wed, Aug 19, 2020 at 7:07 PM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> I don't think it make sense to use the FreeBSD implementation with this
> amount of #ifndef __rtems__.
>
> I will send a new patch with for the changes in test
and remove ifdef __rtems__ and code inside
I don't think it make sense to use the FreeBSD implementation with this
amount of #ifndef __rtems__.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
On 19/08/2020 15:04, Eshan dhawan wrote:
diff --git a/testsuites/psxtests/psxconfstr/init.c
b/testsuites/psxtests/psxconfstr/init.c
new file mode 100644
index 00..8660f04b29
--- /dev/null
+++ b/testsuites/psxtests/psxconfstr/init.c
@@ -0,0 +1,137 @@
+/*
+ * @file
+ * @brief Test suite
