Re: [PATCH] Avoid StopIteration exception for non-rtems .pc

2023-10-05 Thread Chris Johns
Hi Martin, Thanks for posting the patch. I have pushed it. I have pushed an update after running the change through yapf. I forgot to do that before pushing. I will also add a new function to the rtems module as a separate patch: +def arch_bsp(ctx): +""" Return the list of arch/bsps we are b

Re: [PATCH] Avoid StopIteration exception for non-rtems .pc

2023-10-05 Thread Gedare Bloom
LGTM On Thu, Oct 5, 2023 at 7:40 AM Martin Erik Werner wrote: > > _arch_from_arch_bsp() and _bsp_from_arch_bsp() has overly optimistic > assumptions that the argument must contain a '-'-separated field which > starts with "rtems". These functions are intended to find the target > triplet or the b

Re: [PATCH] Avoid StopIteration exception for non-rtems .pc

2023-10-05 Thread Frank Kühndel
Hello Martin, thanks for the fix. Your patch works for me. I tried with $ ./waf configure --rtems=/opt/rtems/6 --rtems-bsp=arm/xilinx_zynq_a9_qemu $ ./waf $ env QEMU_AUDIO_DRV="none" qemu-system-arm -no-reboot -net none -m 256M -serial null -serial mon:stdio -nographic -M xilinx