Re: [PATCH] Addded test for timer_create with clock_monotonic

2021-07-01 Thread Gedare Bloom
On Wed, Jun 30, 2021 at 6:48 PM zack leung wrote: > > > + remaining = (uint32_t)result->tv_nsec + result->tv_sec; > What does "remaining" mean here? What do you get if you add a > (truncated) nanoseconds value to a seconds value? (Hint: the units > aren't the same, so the arithmetic is meani

Re: [PATCH] Addded test for timer_create with clock_monotonic

2021-06-30 Thread zack leung
> + remaining = (uint32_t)result->tv_nsec + result->tv_sec; What does "remaining" mean here? What do you get if you add a (truncated) nanoseconds value to a seconds value? (Hint: the units aren't the same, so the arithmetic is meaningless.) I thought I could convert it back into the uint32_t

Re: [PATCH] Addded test for timer_create with clock_monotonic

2021-06-29 Thread Gedare Bloom
Hi Zack, Please provide a full name in your git-commit author metadata (git-config.user) Please use a short tag at the start of your commit to identify the scope, in this case, it will be "posix/timer" Check typo "addded" in your commit message. I think this commit is related to a ticket? if it