Re: [PATCH] Add configuration option for single processor applications

2021-03-24 Thread Richi Dubey
> > That depends. I don't think the CPP will handle string concatenation > so well, so a long string like that can cause an exception to the > rule. Otherwise you would end up with something like > #ifndef CONFIGURE_MAXIMUM_PROCESSORS > #error "CONFIGURE_MAXIMUM_PROCESSORS must be defined to

Re: [PATCH] Add configuration option for single processor applications

2021-03-22 Thread Gedare Bloom
On Sun, Mar 21, 2021 at 11:48 PM Richi Dubey wrote: > > Hi! > > Thanks for your review. > >> Why not just copy how SMP EDF deals with this problem? >> https://github.com/richidubey/rtems/blob/d3d1e4bc8e616738bd5892c59f82b174c399fc0b/cpukit/include/rtems/scheduler.h#L124 >> I guess that is the "rig

Re: [PATCH] Add configuration option for single processor applications

2021-03-21 Thread Richi Dubey
Hi! Thanks for your review. Why not just copy how SMP EDF deals with this problem? > > https://github.com/richidubey/rtems/blob/d3d1e4bc8e616738bd5892c59f82b174c399fc0b/cpukit/include/rtems/scheduler.h#L124 > I guess that is the "right way" to put the onus on the application to > specify their co

Re: [PATCH] Add configuration option for single processor applications

2021-03-17 Thread Gedare Bloom
Hi Richi, On Wed, Mar 17, 2021 at 1:06 PM Sebastian Huber wrote: > > On 17/03/2021 19:00, Richi Dubey wrote: > > > Thanks for your quick review. > > > > I think this patch is superfluous. In which scenario do you think > > it is > > necessary? > > > > It is from this mail conversation

Re: [PATCH] Add configuration option for single processor applications

2021-03-17 Thread Sebastian Huber
On 17/03/2021 19:00, Richi Dubey wrote: Thanks for your quick review. I think this patch is superfluous. In which scenario do you think it is necessary? It is from this mail conversation: https://lists.rtems.org/pipermail/devel/2020-September/061845.html

Re: [PATCH] Add configuration option for single processor applications

2021-03-17 Thread Richi Dubey
Thanks for your quick review. I think this patch is superfluous. In which scenario do you think it is > necessary? It is from this mail conversation: https://lists.rtems.org/pipermail/devel/2020-September/061845.html followed by https://lists.rtems.org/pipermail/devel/2020-September/061846.html.

Re: [PATCH] Add configuration option for single processor applications

2021-03-16 Thread Sebastian Huber
On 16/03/2021 16:45, Richi Dubey wrote: This change sets the value of number of processor as 1 for a single processor application. Useful when trying to run a single processor application on a multi processor scheduler. I think this patch is superfluous. In which scenario do you think it is n