Re: [PATCH v2] libmisc/top: Fix the idle time and priorities on SMP

2019-12-15 Thread jameszxj
Agree. Patch v3 is ok except for IDLE's priority. The maximum_priority is defined by diffrent scheduler, scheduler CBS and EDF define it as INT_MAX, so  the priority of IDLE is 2147483647 (‭0x7FFF‬). If normalise the priorities in unmap_priority()​, we can get the expected results from _RTE

Re: [PATCH v2] libmisc/top: Fix the idle time and priorities on SMP

2019-12-15 Thread Chris Johns
On 13/12/19 6:48 pm, jameszxj wrote: >    2. On z7020 board, SMP mode, the RPRI and CPRI of idle seems not > reasonable. Yes they are not. I have posted v3 of this patch and my hope is the API used manages this. If it does not we will need look into why or consider an API to normalise the priorit

Re:[PATCH v2] libmisc/top: Fix the idle time and priorities on SMP

2019-12-12 Thread jameszxj
Hi,    1. "data->current_idle" and "data->idle" should be initialize (_Timestamp_Set_to_zero), or the " Load Average" will not be right.    2. On z7020 board, SMP mode, the RPRI and CPRI of idle seems not reasonable.  ID         | NAME                | RPRI | CPRI   | TIME                | TO