Re: [PATCH V2 1/2] RTEMS GPIO API definition and implementation.

Hello Andre, I created a ticket . Please make the necessary changes. Thanks. Cheers, Ketul On 13 August 2015 at 19:38, André Marques wrote: > On 13-08-2015 14:51, Ketul Shah wrote: > > Hi Andre, > > Thanks for the reply. > > On 13 August 2015 at 19:13, And

Re: [PATCH V2 1/2] RTEMS GPIO API definition and implementation.

On 13-08-2015 14:51, Ketul Shah wrote: Hi Andre, Thanks for the reply. On 13 August 2015 at 19:13, André Marques mailto:andre.lousa.marq...@gmail.com>> wrote: Hello Ketul, On 13-08-2015 13:04, Ketul Shah wrote: Hi Andre, Great API and happy to know that it is merg

Re: [PATCH V2 1/2] RTEMS GPIO API definition and implementation.

Hello Ketul, On 13-08-2015 13:04, Ketul Shah wrote: Hi Andre, Great API and happy to know that it is merged with main line. Eventually I implemented GPIO driver for BBB using this API. After debugging for rtems_gpio_get_value() on BBB I found the following bug. For BBB, GPIO pin nos. varies

Re: [PATCH V2 1/2] RTEMS GPIO API definition and implementation.

On Thu, Aug 13, 2015 at 8:04 AM, Ketul Shah wrote: > Hi Andre, > > Great API and happy to know that it is merged with main line. > > Eventually I implemented GPIO driver for BBB using this API. After debugging > for rtems_gpio_get_value() on BBB I found the following bug. > > For BBB, GPIO pin nos

[PATCH V2 1/2] RTEMS GPIO API definition and implementation.

000..a87b39f --- /dev/null +++ b/c/src/lib/libbsp/shared/gpio.c @@ -0,0 +1,1977 @@ +/** + * @file gpio.c + * + * @ingroup rtems_gpio + * + * @brief RTEMS GPIO API implementation. + */ + +/* + * Copyright (c) 2014-2015 Andre Marques + * + * The license and distribution terms for this file may be +

[PATCH V2 2/2] Raspberry Pi implementation for the RTEMS GPIO API.

Added support for the new RTEMS GPIO API functions. Test cases can be found in https://github.com/asuol/RTEMS_rpi_testing/tree/master/GPIO --- c/src/lib/libbsp/arm/raspberrypi/Makefile.am | 5 + .../raspberrypi/gpio/gpio-interfaces-pi1-rev2.c| 136 + c/src/lib/libbsp/arm

Re: RTEMS GPIO API interrupt handling

On July 19, 2015 5:24:25 AM CDT, "André Marques" wrote: >On 18-07-2015 20:04, Joel Sherrill wrote: >> On July 18, 2015 1:23:13 PM CDT, "André >Marques" wrote: >>> Hello all, >>> >>> as previously pointed by Gedare, the interrupt handl

Re: RTEMS GPIO API interrupt handling

On 18-07-2015 20:04, Joel Sherrill wrote: On July 18, 2015 1:23:13 PM CDT, "André Marques" wrote: Hello all, as previously pointed by Gedare, the interrupt handling code in the RTEMS GPIO API can benefit with the use of a rtems interrupt server. The current design and implementati

Re: RTEMS GPIO API interrupt handling

On July 18, 2015 1:23:13 PM CDT, "André Marques" wrote: >Hello all, > >as previously pointed by Gedare, the interrupt handling code in the >RTEMS GPIO API can benefit with the use of a rtems interrupt server. >The >current design and implementation details of the

RTEMS GPIO API interrupt handling

Hello all, as previously pointed by Gedare, the interrupt handling code in the RTEMS GPIO API can benefit with the use of a rtems interrupt server. The current design and implementation details of the API can be seen in my GSOC blog (https://asuolgsoc2014.wordpress.com/2015/07/14/rtems-gpio

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

On 24-06-2015 15:03, Gedare Bloom wrote: On Tue, Jun 23, 2015 at 6:44 PM, André Marques wrote: On 23-06-2015 17:16, Gedare Bloom wrote: + uint32_t bank; + int handled_count; + int rv; + + gpio = (gpio_pin*) arg; + + bank = gpio->bank_number; Validate args for errors. These tasks are

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

On Tue, Jun 23, 2015 at 6:44 PM, André Marques wrote: > On 23-06-2015 17:16, Gedare Bloom wrote: > + uint32_t bank; > + int handled_count; > + int rv; > + > + gpio = (gpio_pin*) arg; > + > + bank = gpio->bank_number; Validate args for errors. >>

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

On 23-06-2015 17:16, Gedare Bloom wrote: + uint32_t bank; + int handled_count; + int rv; + + gpio = (gpio_pin*) arg; + + bank = gpio->bank_number; Validate args for errors. These tasks are only created by the rtems_gpio_enable_interrupt() function, and all parameters are validated befor

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

>> >> >>> + uint32_t bank; >>> + int handled_count; >>> + int rv; >>> + >>> + gpio = (gpio_pin*) arg; >>> + >>> + bank = gpio->bank_number; >> >> Validate args for errors. > > > These tasks are only created by the rtems_gpio_enable_interrupt() function, > and all parameters are validated befor

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

@brief RTEMS GPIO API implementation. + */ + +/* + * Copyright (c) 2014-2015 Andre Marques + * + * The license and distribution terms for this file may be + * found in the file LICENSE in this distribution or at + * http://www.rtems.org/license/LICENSE. + */ + +#include +#include +#include +#i

Re: [PATCH 2/2] Raspberry Pi implementation for the RTEMS GPIO API.

On Mon, Jun 22, 2015 at 8:01 AM, Andre Marques wrote: > Test cases can be found in https://github.com/asuol/RTEMS_rpi_testing > --- > c/src/lib/libbsp/arm/raspberrypi/Makefile.am | 7 +- > .../raspberrypi/gpio/gpio-interfaces-pi1-rev2.c| 135 + > c/src/lib/libbsp/arm/raspberry

Re: [PATCH 1/2] RTEMS GPIO API definition and implementation.

)/bsp/$(dirstamp) > + $(INSTALL_DATA) $< $(PROJECT_INCLUDE)/bsp/gpio.h > +PREINSTALL_FILES += $(PROJECT_INCLUDE)/bsp/gpio.h > + > diff --git a/c/src/lib/libbsp/shared/gpio.c b/c/src/lib/libbsp/shared/gpio.c > new file mode 100644 > index 000..12cdb29 > --- /dev/nul

[PATCH 1/2] RTEMS GPIO API definition and implementation.

/c/src/lib/libbsp/shared/gpio.c @@ -0,0 +1,1083 @@ +/** + * @file gpio.c + * + * @ingroup rtems_gpio + * + * @brief RTEMS GPIO API implementation. + */ + +/* + * Copyright (c) 2014-2015 Andre Marques + * + * The license and distribution terms for this file may be + * found in the file LICENSE i

[PATCH 2/2] Raspberry Pi implementation for the RTEMS GPIO API.

Test cases can be found in https://github.com/asuol/RTEMS_rpi_testing --- c/src/lib/libbsp/arm/raspberrypi/Makefile.am | 7 +- .../raspberrypi/gpio/gpio-interfaces-pi1-rev2.c| 135 + c/src/lib/libbsp/arm/raspberrypi/gpio/rpi-gpio.c | 334 + .../libbsp/arm/

Re: RTEMS GPIO API

On Sun, Jun 21, 2015 at 7:04 PM, André Marques wrote: > On 16-06-2015 17:54, Gedare Bloom wrote: >> >> On Tue, Jun 16, 2015 at 8:14 AM, André Marques >> wrote: >>> >>> Hello , >>> >>> Thank you for the responses. Sorry for the late response and lengthy >>> mail. >>> >>> At this point the features

Re: RTEMS GPIO API

On 16-06-2015 17:54, Gedare Bloom wrote: On Tue, Jun 16, 2015 at 8:14 AM, André Marques wrote: Hello , Thank you for the responses. Sorry for the late response and lengthy mail. At this point the features mentioned in the blog post are almost done in the code (apart from some details). There

Re: RTEMS GPIO API

On Tue, Jun 16, 2015 at 8:14 AM, André Marques wrote: > Hello , > > Thank you for the responses. Sorry for the late response and lengthy mail. > > At this point the features mentioned in the blog post are almost done in the > code (apart from some details). There are some differences from what is

Re: RTEMS GPIO API

Hello , Thank you for the responses. Sorry for the late response and lengthy mail. At this point the features mentioned in the blog post are almost done in the code (apart from some details). There are some differences from what is mentioned in the blog, but the overall idea still stands (an b

Re: RTEMS GPIO API

On Wed, Jun 10, 2015 at 7:09 PM, Chris Johns wrote: > On 11/06/2015 3:01 am, Gedare Bloom wrote: >> On Mon, Jun 8, 2015 at 5:44 AM, André Marques >> wrote: >>> Hello, >>> >>> I have just updated my GSOC blog [1] with a detailed post about how a >>> rtems-wide GPIO API could look like, and at the

Re: RTEMS GPIO API

On 11/06/2015 3:01 am, Gedare Bloom wrote: > On Mon, Jun 8, 2015 at 5:44 AM, André Marques > wrote: >> Hello, >> >> I have just updated my GSOC blog [1] with a detailed post about how a >> rtems-wide GPIO API could look like, and at the same time exposing the >> current features of the Raspberry P

Re: RTEMS GPIO API

th the libdrvmgr. This is a long-term question but might be one worth thinking about now. (libdrvmgr mainly focuses on providing abstractions for device drivers that attached to bus-based i/o protocols. You may like to take a look at its documentation.) > [1] - https://asuolgsoc2014.wordp

RTEMS GPIO API

suggestions, or ask for clarifications. It would also be interesting to hear the community expectations towards an API such as this one. [1] - https://asuolgsoc2014.wordpress.com/2015/06/08/rtems-gpio-api/ [2] - https://github.com/asuol/rtems/tree/GPIO_API/c/src/lib/libbsp/arm/raspberrypi/gpio Thanks