Re: [PATCH] posix: Only check shm_unlink obj_err if necessary

2020-06-29 Thread Gedare Bloom
This looks fine for someone to push to master, along with the other one for 5.1 On Tue, Jan 28, 2020 at 11:37 AM Kinsey Moore wrote: > > In the nominal case checked by spsysinit01, obj_err is unmodified if > _POSIX_Shm_Get_by_name returns non-NULL. In the case of shm_unlink, this > means an unini

RE: [PATCH] posix: Only check shm_unlink obj_err if necessary

2020-06-27 Thread Kinsey Moore
Sorry, accidentally sent from my personal account. That was, in fact, me. Kinsey From: Will Sent: Saturday, June 27, 2020 19:24 To: Gedare Bloom Cc: Kinsey Moore ; devel@rtems.org Subject: Re: [PATCH] posix: Only check shm_unlink obj_err if necessary Ticket 4016 opened for 5.1 and patch sent

Re: [PATCH] posix: Only check shm_unlink obj_err if necessary

2020-06-27 Thread Will
t can), the current logic treats that >> as a success and operates on a NULL pointer. >> >> -Original Message- >> From: Gedare Bloom >> Sent: Thursday, June 25, 2020 16:49 >> To: Kinsey Moore >> Cc: devel@rtems.org >> Subject: Re: [PATCH

Re: [PATCH] posix: Only check shm_unlink obj_err if necessary

2020-06-27 Thread Gedare Bloom
0 16:49 > To: Kinsey Moore > Cc: devel@rtems.org > Subject: Re: [PATCH] posix: Only check shm_unlink obj_err if necessary > > Hi Kinsey, > > I missed seeing this. Two quick questions for you. > > 1. does it also work to initialize obj_err to 0? that would be

RE: [PATCH] posix: Only check shm_unlink obj_err if necessary

2020-06-25 Thread Kinsey Moore
ginal Message- From: Gedare Bloom Sent: Thursday, June 25, 2020 16:49 To: Kinsey Moore Cc: devel@rtems.org Subject: Re: [PATCH] posix: Only check shm_unlink obj_err if necessary Hi Kinsey, I missed seeing this. Two quick questions for you. 1. does it also work to initialize obj_err to 0? that

Re: [PATCH] posix: Only check shm_unlink obj_err if necessary

2020-06-25 Thread Gedare Bloom
Hi Kinsey, I missed seeing this. Two quick questions for you. 1. does it also work to initialize obj_err to 0? that would be simpler code. 2. I see the error handling logic changes slightly, with OBJECTS_GET_BY_NAME_NO_OBJECT now returning ENOENT. I guess if it works to init obj_err to 0, this c

RE: [PATCH] posix: Only check shm_unlink obj_err if necessary

2020-06-25 Thread Kinsey Moore
Is there anything stopping this from being merged? I just ran into this bug again on the current project I'm working on. Kinsey -Original Message- From: Kinsey Moore Sent: Tuesday, January 28, 2020 12:37 To: devel@rtems.org Cc: Kinsey Moore Subject: [PATCH] posix: Only check shm_unlin