Re: RE:[PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-07 Thread Joel Sherrill
On Fri, Apr 7, 2017 at 9:58 AM, Gedare Bloom wrote: > On Fri, Apr 7, 2017 at 10:05 AM, Joel Sherrill wrote: > > > > > > On Fri, Apr 7, 2017 at 4:15 AM, Cillian O'Donnell > > > wrote: > >> > >> Great! That looks like a cleaner, more standardized solution. I was just > >> hacking away until the w

Re: RE:[PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-07 Thread Gedare Bloom
On Fri, Apr 7, 2017 at 10:05 AM, Joel Sherrill wrote: > > > On Fri, Apr 7, 2017 at 4:15 AM, Cillian O'Donnell > wrote: >> >> Great! That looks like a cleaner, more standardized solution. I was just >> hacking away until the warnings stopped. So can I go ahead and #include >> or should I wait unt

Re: RE:[PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-07 Thread Joel Sherrill
On Fri, Apr 7, 2017 at 4:15 AM, Cillian O'Donnell wrote: > Great! That looks like a cleaner, more standardized solution. I was just > hacking away until the warnings stopped. So can I go ahead and #include > or should I wait until is defined before > doing any more? Does this work for printk()

Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Joel Sherrill
I filed a ticket (https://devel.rtems.org/ticket/2983) so we can fine tune the proposal and track it. --joel On Thu, Apr 6, 2017 at 5:39 PM, Joel Sherrill wrote: > > > On Thu, Apr 6, 2017 at 5:37 PM, Gedare Bloom wrote: > >> On Thu, Apr 6, 2017 at 6:30 PM, Joel Sherrill wrote: >> > Following

Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Joel Sherrill
On Thu, Apr 6, 2017 at 5:37 PM, Gedare Bloom wrote: > On Thu, Apr 6, 2017 at 6:30 PM, Joel Sherrill wrote: > > Following up on my own post. You can avoid some casts. > > This is also an example of how pulling a thread can lead > > somewhere more complicated. :) > > > > %z should work portably fo

Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Gedare Bloom
On Thu, Apr 6, 2017 at 6:30 PM, Joel Sherrill wrote: > Following up on my own post. You can avoid some casts. > This is also an example of how pulling a thread can lead > somewhere more complicated. :) > > %z should work portably for size_t and should avoid a cast. > > libdl already has this in li

Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Joel Sherrill
Following up on my own post. You can avoid some casts. This is also an example of how pulling a thread can lead somewhere more complicated. :) %z should work portably for size_t and should avoid a cast. libdl already has this in libdl/rtl-shell.c which tries to provide a C99 inttypes.h like const

Re: [PATCH] Update:Change format specifiers to fix 4 warnings.

2017-04-06 Thread Joel Sherrill
Thanks. I am rebuilding all my tools so am not in a position to start a test of this until in the morning. I am not saying your patch is wrong. But speaking from experience, the answer to portable warning free printf() formats is often inttypes.h. Especially if some have system types or are like