Re: [PATCH] Adding functionalities to Mailbox RPi

2016-06-28 Thread Pavel Pisa
Hello Mudit and others, On Monday 27 of June 2016 15:09:39 Mudit Jain wrote: > Hi, > > Any consensus regarding the issue ? > Do we go forward with the present implementation or a change is required ? I have pushed your patch to move development forward. I have run RTEMS uncrustify on VideoCore so

Re: [PATCH] Adding functionalities to Mailbox RPi

2016-06-27 Thread Mudit Jain
Hi, Any consensus regarding the issue ? Do we go forward with the present implementation or a change is required ? I have another change for getting and setting the clock rate which is by the driver. I can push the same along with the cosmetic changes done by uncrustify. Thanks Mudit On Fri, J

Re: [PATCH] Adding functionalities to Mailbox RPi

2016-06-24 Thread Gedare Bloom
On Mon, Jun 20, 2016 at 5:17 PM, Mudit Jain wrote: > From: muditj > > Added functions for retrieving firmware revision, > board model and board revision. > --- > c/src/lib/libbsp/arm/raspberrypi/include/vc.h | 19 +++ > c/src/lib/libbsp/arm/raspberrypi/misc/vc.c | 60 >

Re: [PATCH] Adding functionalities to Mailbox RPi

2016-06-24 Thread Pavel Pisa
Hello Mudit and Gedare, On Friday 24 of June 2016 12:02:36 Mudit Jain wrote: > Hi Gedare, > > When I use uncrustify, it makes a lot of changes to the previous code as > well. We can have another patch over this for the cosmetic changes. > > I myself, did have doubts regarding the empty struct and

Re: [PATCH] Adding functionalities to Mailbox RPi

2016-06-24 Thread Mudit Jain
Hi Gedare, When I use uncrustify, it makes a lot of changes to the previous code as well. We can have another patch over this for the cosmetic changes. I myself, did have doubts regarding the empty struct and having two structs that are basically identical, however previously it was implemented i

[PATCH] Adding functionalities to Mailbox RPi

2016-06-20 Thread Mudit Jain
From: muditj Added functions for retrieving firmware revision, board model and board revision. --- c/src/lib/libbsp/arm/raspberrypi/include/vc.h | 19 +++ c/src/lib/libbsp/arm/raspberrypi/misc/vc.c | 60 ++ c/src/lib/libbsp/arm/raspberrypi/misc/vc_defines.h |

Re: Adding functionalities to Mailbox RPi

2016-06-20 Thread Pavel Pisa
Hello Mudit, On Monday 20 of June 2016 15:59:16 Mudit Jain wrote: > Hi, > > I have added functionality to retrieve the firmware version, board model > number and board revision to the mail box code. This was one of the > deliverables of my project. > > Github Link : > https://github.com/spark1729/

Adding functionalities to Mailbox RPi

2016-06-20 Thread Mudit Jain
Hi, I have added functionality to retrieve the firmware version, board model number and board revision to the mail box code. This was one of the deliverables of my project. Github Link : https://github.com/spark1729/rtems/commit/796231efc7b0f6dd1adce67f21615689a1b0224b This is in accordance with