Re: [rtems-tools PATCH] rtemstoolkit: Fix shell execution

2023-08-29 Thread Chris Johns
On 30/8/2023 5:44 am, Joel Sherrill wrote: > A bit more feedback. I got this failure on CentOS 7 building sparc-rtems6 > tools. > > + cd rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8 > + ./waf distclean configure --prefix=/home/joel/rtems-work/tools/6 > 'distclean' finished successfully (0

Re: [rtems-tools PATCH] rtemstoolkit: Fix shell execution

2023-08-29 Thread Joel Sherrill
A bit more feedback. I got this failure on CentOS 7 building sparc-rtems6 tools. + cd rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8 + ./waf distclean configure --prefix=/home/joel/rtems-work/tools/6 'distclean' finished successfully (0.001s) Setting top to : /home/

Re: [rtems-tools PATCH] rtemstoolkit: Fix shell execution

2023-08-29 Thread Joel Sherrill
On Tue, Aug 29, 2023 at 5:48 AM Frank Kühndel < frank.kuehn...@embedded-brains.de> wrote: > Hello Chris, > > On 8/29/23 12:45, Chris Johns wrote: > >> On 29 Aug 2023, at 6:24 pm, Frank Kühndel< > frank.kuehn...@embedded-brains.de> wrote: > >> > >> Hello Chris, > >> > >> our continuous integratio

Re: [rtems-tools PATCH] rtemstoolkit: Fix shell execution

2023-08-29 Thread Frank Kühndel
Hello Chris, On 8/29/23 12:45, Chris Johns wrote: On 29 Aug 2023, at 6:24 pm, Frank Kühndel wrote: Hello Chris, our continuous integration server found an issues with this patch ("module 'shlex' has no attribute 'join'"): Frank, thanks for the post and the insight. I saw the build break in

Re: [rtems-tools PATCH] rtemstoolkit: Fix shell execution

2023-08-29 Thread Chris Johns
> On 29 Aug 2023, at 6:24 pm, Frank Kühndel > wrote: > > Hello Chris, > > our continuous integration server found an issues with this patch > ("module 'shlex' has no attribute 'join'"): Frank, thanks for the post and the insight. I saw the build break in Joel’s build but I could not see the

Re: [rtems-tools PATCH] rtemstoolkit: Fix shell execution

2023-08-29 Thread Frank Kühndel
mail. If you have a fix, I am happy to test it. Greetings, Frank On 8/28/23 08:47, chr...@rtems.org wrote: Subject: [rtems-tools PATCH] rtemstoolkit: Fix shell execution From: chr...@rtems.org Date: 8/28/23, 08:47 To: devel@rtems.org From: Chris Johns The fixes to parse the command along with

[rtems-tools PATCH] rtemstoolkit: Fix shell execution

2023-08-27 Thread chrisj
From: Chris Johns The fixes to parse the command along with the pipe options broke a simple shell command such as '/sbin/sysctl hw.ncpu' on FreeBSD. This patch fixes the shell command by passing a string for the various options. The unit test has been updated to catch errors and report them. ---