gards,
Adrien
From: Sebastian Huber
Sent: 01 February 2024 07:58
To: Adrien Chardon ; devel@rtems.org
Subject: Re: [Patch] bsp/tms570/sci: fix bug in tms570_sci_read_received_chars()
[You don't often get email from sebastian.hu...@embedded-brains.de. Learn why
this is important
Huber
Sent: 01 February 2024 08:03
To: devel@rtems.org
Cc: Chris Johns ; Adrien Chardon
Subject: Re: [Patch] bsp/tms570/sci: fix bug in tms570_sci_read_received_chars()
[You don't often get email from sebastian.hu...@embedded-brains.de. Learn why
this is important at https://aka.ms/LearnAboutSe
Hello Adrien,
On 31.01.24 18:35, Adrien Chardon wrote:
While testing the counterpart of my protocol on a Zynq, I found a
similar issue
where the UART is assumed to be used for printable text only. The second
patch
fixes it.
I am not sure about this patch. It changes the initialization. The
On 31.01.24 18:35, Adrien Chardon wrote:
You will find attached the Git patch file for the SCI bug. I've taken into
account your suggestions.
Thanks, I checked in this patch with some changes since it didn't apply
on the master branch. I guess you have some additional local modifications.
--
now.
Best regards,
Adrien Chardon, on behalf of Reflex Aerospace
From: Sebastian Huber
Sent: 25 January 2024 20:29
To: Adrien Chardon ; devel@rtems.org
Subject: Re: [Patch] bsp/tms570/sci: fix bug in tms570_sci_read_received_chars()
[You don't often
Hello Adrien,
the change looks good. I would remove the
tms570_sci_read_received_chars() and TMS570_SCI_BUFFER_SIZE:
static void tms570_sci_interrupt_handler(void * arg)
{
rtems_termios_tty *tty = arg;
tms570_sci_context *ctx = rtems_termios_get_device_context(tty);
/*
* Check if we
Hi all,
(First time posting on a Mailing List, I apologize if I'm breaking any rule)
(For the record: this work is done during my work hours at Reflex Aerospace)
I believe that I found a bug in the TMS570 BSP, more specifically the receiving
part of the SCI driver. Please find attached the git di