Re: [PATCH v6] tests for fenv.h functions

2020-03-20 Thread Eshan Dhawan
On Sat, Mar 21, 2020 at 1:35 AM Joel Sherrill wrote: > > > On Fri, Mar 20, 2020 at 2:50 PM Gedare Bloom wrote: > >> On Sun, Mar 8, 2020 at 11:02 AM Eshan Dhawan >> wrote: >> > >> > I have compiled as well as executed it for RISC V architecture function >> Fegetround() returns error for all roun

Re: [PATCH v6] tests for fenv.h functions

2020-03-20 Thread Eshan Dhawan
I will patch that up On Sat, Mar 21, 2020 at 1:25 AM Aditya Upadhyay wrote: > Hi Eshan, > > You should look into the RTEMS Coding conventions and rules. I can see > that some spaces that you inserted after > rtems_test_assert() were not needed. Please remove these unnecessary > spaces. For examp

Re: [PATCH v6] tests for fenv.h functions

2020-03-20 Thread Joel Sherrill
On Fri, Mar 20, 2020 at 2:50 PM Gedare Bloom wrote: > On Sun, Mar 8, 2020 at 11:02 AM Eshan Dhawan > wrote: > > > > I have compiled as well as executed it for RISC V architecture function > Fegetround() returns error for all rounding directions other the default > "FETONEAREST" I asked about it

Re: [PATCH v6] tests for fenv.h functions

2020-03-20 Thread Aditya Upadhyay
Hi Eshan, You should look into the RTEMS Coding conventions and rules. I can see that some spaces that you inserted after rtems_test_assert() were not needed. Please remove these unnecessary spaces. For example, rtems_test_assert ( r == 0 ) ; ===> should be changed to rtems_test_assert( r == 0 )

Re: [PATCH v6] tests for fenv.h functions

2020-03-20 Thread Gedare Bloom
On Sun, Mar 8, 2020 at 11:02 AM Eshan Dhawan wrote: > > I have compiled as well as executed it for RISC V architecture function > Fegetround() returns error for all rounding directions other the default > "FETONEAREST" I asked about it on devel to which dr Joel told that it is due > to soft-flo

Re: [PATCH v6] tests for fenv.h functions

2020-03-20 Thread Eshan Dhawan
On Sat, Mar 21, 2020 at 12:19 AM Eshan Dhawan wrote: > Hello Everyone, > I had sent this patch a few days ago to add tests of fenv.h to psxtests. > If you all could look into it and tell if it could be merged or requires > any more changes. > > link to patch :* https://lists.rtems.org/pipermail/d

Re: [PATCH v6] tests for fenv.h functions

2020-03-20 Thread Eshan Dhawan
Hello Everyone, I had sent this patch a few days ago to add tests of fenv.h to psxtests. If you all could look into it and tell if it could be merged or requires any more changes. thanks, Eshan Dhawan On Sun, Mar 8, 2020 at 10:32 PM Eshan Dhawan wrote: > I have compiled as well as executed it

Re: [PATCH v6] tests for fenv.h functions

2020-03-08 Thread Eshan Dhawan
I have compiled as well as executed it for RISC V architecture function Fegetround() returns error for all rounding directions other the default "FETONEAREST" I asked about it on devel to which dr Joel told that it is due to soft-float. So I have added its test case but they won't work on emulators

Re: [PATCH v6] tests for fenv.h functions

2020-03-08 Thread Gedare Bloom
Hi Eshan, This is looking good. Did you compile it? Execute it? How was the output? On Sat, Mar 7, 2020 at 6:51 AM Eshan dhawan wrote: > > --- > testsuites/psxtests/psxfenv01/init.c | 89 ++-- > 1 file changed, 71 insertions(+), 18 deletions(-) > > diff --git a/testsuit

[PATCH v6] tests for fenv.h functions

2020-03-07 Thread Eshan dhawan
--- testsuites/psxtests/psxfenv01/init.c | 89 ++-- 1 file changed, 71 insertions(+), 18 deletions(-) diff --git a/testsuites/psxtests/psxfenv01/init.c b/testsuites/psxtests/psxfenv01/init.c index cdb0fa596e..6d71463465 100644 --- a/testsuites/psxtests/psxfenv01/init.c ++