Re: [PATCH v4 2/2] Adding trace documentation

2018-06-13 Thread Vidushi Vashishth
>Oh that maybe a mistake. Which section? I cross checked, it does'nt exist in the current documentation. I think I must have misinterpreted it. >Yes please that would be good then we can have some documentation for what >exists pushed to master. I have sent the v5 patches. Please review and let

Re: [PATCH v4 2/2] Adding trace documentation

2018-06-12 Thread Chris Johns
On 13/06/2018 13:04, Vidushi Vashishth wrote: > > I have made the changes you suggested. Thanks. > I am still working on CTF support. > >>> +  $ ../samples >>What is this command? > > This is not a command. It is used to show which directory we are in. This > method > was used in the quicksta

Re: [PATCH v4 2/2] Adding trace documentation

2018-06-12 Thread Vidushi Vashishth
Hi I have made the changes you suggested. I am still working on CTF support. >> + $ ../samples >What is this command? This is not a command. It is used to show which directory we are in. This method was used in the quickstart section. But I have removed this. >There is some doco that would be

Re: [PATCH v4 2/2] Adding trace documentation

2018-06-12 Thread Chris Johns
Hi, This documentation looks good and I welcome this being done and added to the RTEMS project. I have some comments below I hope are easy to resolve. Thanks Chris On 13/06/2018 11:23, Vidushi Vashishth wrote: > --- > user/index.rst | 2 + > user/tracing/captureengine.rst | 1

[PATCH v4 2/2] Adding trace documentation

2018-06-12 Thread Vidushi Vashishth
--- user/index.rst | 2 + user/tracing/captureengine.rst | 184 ++ user/tracing/examples.rst | 12 ++ user/tracing/index.rst | 29 + user/tracing/introduction.rst | 182 ++ user/tracing/tracelinker.rst | 287 ++