Re: mmap shared stack design was: [PATCH v4 1/3] Strict thread-stack isolation

2020-08-24 Thread Gedare Bloom
On Mon, Aug 24, 2020 at 10:41 AM Utkarsh Rai wrote: > > > > On Mon, Aug 24, 2020 at 9:34 PM Gedare Bloom wrote: >> >> On Sat, Aug 22, 2020 at 11:27 PM Utkarsh Rai wrote: >> > >> > >> > >> > On Sat, Aug 22, 2020 at 11:32 PM Gedare Bloom wrote: >> >> >> >> I have some comments below. I'm not that

Re: mmap shared stack design was: [PATCH v4 1/3] Strict thread-stack isolation

2020-08-24 Thread Utkarsh Rai
On Mon, Aug 24, 2020 at 9:34 PM Gedare Bloom wrote: > On Sat, Aug 22, 2020 at 11:27 PM Utkarsh Rai > wrote: > > > > > > > > On Sat, Aug 22, 2020 at 11:32 PM Gedare Bloom wrote: > >> > >> I have some comments below. I'm not that happy with the lack of design > >> discussion during the iteration

mmap shared stack design was: [PATCH v4 1/3] Strict thread-stack isolation

2020-08-24 Thread Gedare Bloom
On Sat, Aug 22, 2020 at 11:27 PM Utkarsh Rai wrote: > > > > On Sat, Aug 22, 2020 at 11:32 PM Gedare Bloom wrote: >> >> I have some comments below. I'm not that happy with the lack of design >> discussion during the iteration of this code. While it is a little >> easier to critique the code, it is

Re: [PATCH v4 1/3] Strict thread-stack isolation

2020-08-22 Thread Utkarsh Rai
On Sat, Aug 22, 2020 at 11:32 PM Gedare Bloom wrote: > I have some comments below. I'm not that happy with the lack of design > discussion during the iteration of this code. While it is a little > easier to critique the code, it is also a bit wasteful because I have > to also comment on stylistic

Re: [PATCH v4 1/3] Strict thread-stack isolation

2020-08-22 Thread Gedare Bloom
I have some comments below. I'm not that happy with the lack of design discussion during the iteration of this code. While it is a little easier to critique the code, it is also a bit wasteful because I have to also comment on stylistic problems, and when some decisions you make while coding end up

[PATCH v4 1/3] Strict thread-stack isolation

2020-08-22 Thread Utkarsh Rai
- These patches are based on the new build system. - Allocation of page aligned stack has been done through posix_memalign(), which is a hack. --- .../realview-pbx-a9/mmu/bsp-set-mmu-attr.c| 90 + bsps/shared/start/stackalloc.c| 12 +- cpukit/include/rtems/scor