Re: [PATCH v3 1/3] cpukit/flash: Add API for Flash devices

2023-04-26 Thread Gedare Bloom
I'm satisfied with the API. I have a couple minor comments on the implementation. On Thu, Apr 20, 2023 at 1:23 AM wrote: > > From: Aaron Nyholm > > --- > cpukit/dev/flash/flashdev.c | 849 > cpukit/include/dev/flash/flashdev.h | 458 +++ > spec/

Re: [PATCH v3 1/3] cpukit/flash: Add API for Flash devices

2023-04-23 Thread Kinsey Moore
Great, if you could add a note to that IOCTL to that effect before commit, that'd be great since consumers shouldn't rely on it to alter their consumption of the API. Otherwise, looks good to me! Kinsey On Apr 23, 2023, at 21:45, Aaron Nyholm mailto:aaron.nyh...@unfoldedeffective.com>> wrote:

Re: [PATCH v3 1/3] cpukit/flash: Add API for Flash devices

2023-04-23 Thread Aaron Nyholm
Yes, it is purely informational. It just returns the 3-byte JEDEC ID. Regards, Aaron. --- Original Message --- On Monday, April 24th, 2023 at 12:35 PM, Kinsey Moore wrote: > I noticed that there is provision here to pass through the JEDEC ID from the > physical device (obtained by a

Re: [PATCH v3 1/3] cpukit/flash: Add API for Flash devices

2023-04-23 Thread Kinsey Moore
I noticed that there is provision here to pass through the JEDEC ID from the physical device (obtained by a JEDEC parameter page read, ONFI parameter page read, or other mechanism). Is this intended to be purely informational? Kinsey On Thu, Apr 20, 2023 at 2:23 AM wrote: > From: Aaron Nyholm

[PATCH v3 1/3] cpukit/flash: Add API for Flash devices

2023-04-20 Thread aaron . nyholm
From: Aaron Nyholm --- cpukit/dev/flash/flashdev.c | 849 cpukit/include/dev/flash/flashdev.h | 458 +++ spec/build/cpukit/librtemscpu.yml | 4 + 3 files changed, 1311 insertions(+) create mode 100644 cpukit/dev/flash/flashdev.c create mode