Re: [PATCH v3] bsp/beagle: Update console to new Termios API.

On 10/04/2020 20:53, Niteesh G. S. wrote: > On Fri, Apr 10, 2020 at 9:18 PM Christian Mauderer > wrote: > > Hello Niteesh, > > sorry for the late review. It somehow slipped my attention. > > Although I'm generally OK with it, my suggestion would be to move

Re: [PATCH v3] bsp/beagle: Update console to new Termios API.

On Fri, Apr 10, 2020 at 9:18 PM Christian Mauderer wrote: > Hello Niteesh, > > sorry for the late review. It somehow slipped my attention. > > Although I'm generally OK with it, my suggestion would be to move it > after the release. It's a not strictly necessary change and therefore I > don't wan

Re: [PATCH v3] bsp/beagle: Update console to new Termios API.

Hello Niteesh, sorry for the late review. It somehow slipped my attention. Although I'm generally OK with it, my suggestion would be to move it after the release. It's a not strictly necessary change and therefore I don't want to potentially break stuff with it now. I added some comments below:

[PATCH v3] bsp/beagle: Update console to new Termios API.

This patch updates the console driver to new Termios API. Update #3034 --- bsps/arm/beagle/console/console-config.c | 117 +-- c/src/lib/libbsp/arm/beagle/Makefile.am | 4 +- 2 files changed, 69 insertions(+), 52 deletions(-) diff --git a/bsps/arm/beagle/console/console-co