Re: [PATCH v3] Raspberrypi: updated the console interface.

On 30/12/2019 16:02, Niteesh wrote: > On Mon, Dec 30, 2019 at 6:56 PM Christian Mauderer > wrote: > > On 30/12/2019 09:21, Niteesh wrote: > > I just looked at the dts files for rpi4, the uart 0, uart 1 are the > > same, the additional 4 uarts are in differen

Re: [PATCH v3] Raspberrypi: updated the console interface.

On Mon, Dec 30, 2019 at 6:56 PM Christian Mauderer wrote: > On 30/12/2019 09:21, Niteesh wrote: > > I just looked at the dts files for rpi4, the uart 0, uart 1 are the > > same, the additional 4 uarts are in different pins and can be used > > simultaneously. They are all pl011 and are disabled by

Re: [PATCH v3] Raspberrypi: updated the console interface.

On 30/12/2019 09:21, Niteesh wrote: > I just looked at the dts files for rpi4, the uart 0, uart 1 are the > same, the additional 4 uarts are in different pins and can be used > simultaneously. They are all pl011 and are disabled by default, and are > enabled using overlays in linux. Do you want to

Re: [PATCH v3] Raspberrypi: updated the console interface.

I just looked at the dts files for rpi4, the uart 0, uart 1 are the same, the additional 4 uarts are in different pins and can be used simultaneously. They are all pl011 and are disabled by default, and are enabled using overlays in linux. Do you want to handle then now or sometime later? On Mon,

Re: [PATCH v3] Raspberrypi: updated the console interface.

On Mon, 30 Dec, 2019, 2:07 AM Christian Mauderer, wrote: > I assume you want suggestions regarding this code rather than the > original patch? > > One suggestion: If you post code please try to use a mail program that > keeps the indentation. It's hard to read in this form. But that's most > like

Re: [PATCH v3] Raspberrypi: updated the console interface.

I assume you want suggestions regarding this code rather than the original patch? One suggestion: If you post code please try to use a mail program that keeps the indentation. It's hard to read in this form. But that's most likely not the suggestion you searched for ;-) On 29/12/2019 19:48, Nitee

Re: [PATCH v3] Raspberrypi: updated the console interface.

On 29/12/2019 18:44, Niteesh wrote: > Where does RTEMS except the DTB file to be present? See my mail in the other thread regarding that. You might have to add a define in the configure.ac. > > On Sun, Dec 29, 2019 at 8:27 PM Niteesh > wrote: > > I am sorry, I sen

Re: [PATCH v3] Raspberrypi: updated the console interface.

I am not happy with my code at all, I can please provide some suggestions. On Mon, Dec 30, 2019 at 12:17 AM Niteesh wrote: > arm_pl011_context pl011_context; > rpi_fb_context fb_context; > char uart_instance[20]; > > > static void output_char_serial(char c) > { > arm_pl011_write_polled(&pl011_co

Re: [PATCH v3] Raspberrypi: updated the console interface.

arm_pl011_context pl011_context; rpi_fb_context fb_context; char uart_instance[20]; static void output_char_serial(char c) { arm_pl011_write_polled(&pl011_context.base, c); } void output_char_fb(char c) { fbcons_write_polled(&fb_context.base, c); } static void *get_reg_of_node(const void *fdt,

Re: [PATCH v3] Raspberrypi: updated the console interface.

Where does RTEMS except the DTB file to be present? On Sun, Dec 29, 2019 at 8:27 PM Niteesh wrote: > I am sorry, I sent the previous without testing and building, so it might > contain some errors. > Just tell me if you are happy with the code, I will fix all the error's > and send in a new patc

Re: [PATCH v3] Raspberrypi: updated the console interface.

I am sorry, I sent the previous without testing and building, so it might contain some errors. Just tell me if you are happy with the code, I will fix all the error's and send in a new patch. On Sun, Dec 29, 2019 at 8:04 PM G S Niteesh wrote: > The patch updates the older console interface used

[PATCH v3] Raspberrypi: updated the console interface.

The patch updates the older console interface used by the BSP, to newer one. It also replaces the custom usart(PL011) driver with arm-pl011. The fb function's signatures where also changed to accommodate with interface update. Update #3034 --- bsps/arm/raspberrypi/console/console-config.c | 182 ++