Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-09-16 Thread Gedare Bloom
Martin, Please send a v4 that applies over Sudarshan's patch (attached). Then we can commit both. Thanks! On Wed, Sep 16, 2015 at 2:18 AM, Sebastian Huber wrote: > Is there a v4 missing? > > > On 14/09/15 23:49, Martin Galvan wrote: >> >> Hi everyone! Just checking in, was Sudarshan's patch com

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-09-15 Thread Sebastian Huber
Is there a v4 missing? On 14/09/15 23:49, Martin Galvan wrote: Hi everyone! Just checking in, was Sudarshan's patch commited? On Mon, Aug 31, 2015 at 4:49 PM, Gedare Bloom wrote: Martin's ticket works, and his commit can #close it. On Mon, Aug 31, 2015 at 3:22 PM, sudarshan.rajagopalan wro

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-09-14 Thread Martin Galvan
Hi everyone! Just checking in, was Sudarshan's patch commited? On Mon, Aug 31, 2015 at 4:49 PM, Gedare Bloom wrote: > Martin's ticket works, and his commit can #close it. > > On Mon, Aug 31, 2015 at 3:22 PM, sudarshan.rajagopalan > wrote: >> On 2015-08-31 13:39, Daniel Gutson wrote: >>> >>> On

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-08-31 Thread Gedare Bloom
Martin's ticket works, and his commit can #close it. On Mon, Aug 31, 2015 at 3:22 PM, sudarshan.rajagopalan wrote: > On 2015-08-31 13:39, Daniel Gutson wrote: >> >> On Mon, Aug 31, 2015 at 2:34 PM, Gedare Bloom wrote: >>> >>> I'd approve 2 patches in case you want to give credit. First patch >>

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-08-31 Thread sudarshan.rajagopalan
On 2015-08-31 13:39, Daniel Gutson wrote: On Mon, Aug 31, 2015 at 2:34 PM, Gedare Bloom wrote: I'd approve 2 patches in case you want to give credit. First patch with Sudarshan's fix, and Martin's improvement second. +1 Sounds fair enough! :) Thanks for the support, Daniel. Should I make a

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-08-31 Thread Daniel Gutson
On Mon, Aug 31, 2015 at 2:34 PM, Gedare Bloom wrote: > I'd approve 2 patches in case you want to give credit. First patch > with Sudarshan's fix, and Martin's improvement second. +1 > > On Mon, Aug 31, 2015 at 1:28 PM, Daniel Gutson > wrote: >> Side question to Joel and others: is this enough t

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-08-31 Thread Martin Galvan
On Mon, Aug 31, 2015 at 2:34 PM, Gedare Bloom wrote: > I'd approve 2 patches in case you want to give credit. First patch > with Sudarshan's fix, and Martin's improvement second. Agreed. Sudarshan sent his patch a couple days ago; I'll generate a new one with the new instructions and the comments

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-08-31 Thread Gedare Bloom
I'd approve 2 patches in case you want to give credit. First patch with Sudarshan's fix, and Martin's improvement second. On Mon, Aug 31, 2015 at 1:28 PM, Daniel Gutson wrote: > Side question to Joel and others: is this enough to credit Sudarshan? > He did an amazing job for finding the bug and p

Re: [PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-08-31 Thread Daniel Gutson
Side question to Joel and others: is this enough to credit Sudarshan? He did an amazing job for finding the bug and proposing an initial solution. On Mon, Aug 31, 2015 at 11:37 AM, Martin Galvan wrote: > On exception entry, _ARMV7M_Exception_default stores the previous Stack > Pointer > in a CPU

[PATCH v3] ARMv7M: Fix exception handler for supporting FPU

2015-08-31 Thread Martin Galvan
On exception entry, _ARMV7M_Exception_default stores the previous Stack Pointer in a CPU_Exception_frame. The SP can be MSP or PSP, depending on the mode in which the exception was taken. To know this, we must check the value of LR. Right now the code checks whether it should store MSP or PSP by c