Re: [PATCH v2 4/4] posix/src/mutexinit.c: Reorder to make priority a scoped variable

2017-04-27 Thread Joel Sherrill
On Thu, Apr 27, 2017 at 3:40 PM, Gedare Bloom wrote: > On Wed, Apr 26, 2017 at 10:59 PM, Joel Sherrill wrote: > > > > > > On Wed, Apr 26, 2017 at 9:02 PM, Gedare Bloom wrote: > >> > >> I might rather see the switch refactored to an if-then block, since it > >> has quite a bit of structure to it

Re: [PATCH v2 4/4] posix/src/mutexinit.c: Reorder to make priority a scoped variable

2017-04-27 Thread Gedare Bloom
On Wed, Apr 26, 2017 at 10:59 PM, Joel Sherrill wrote: > > > On Wed, Apr 26, 2017 at 9:02 PM, Gedare Bloom wrote: >> >> I might rather see the switch refactored to an if-then block, since it >> has quite a bit of structure to it now. >> > > How about it includes all cases? > It is better written

Re: [PATCH v2 4/4] posix/src/mutexinit.c: Reorder to make priority a scoped variable

2017-04-26 Thread Joel Sherrill
On Wed, Apr 26, 2017 at 9:02 PM, Gedare Bloom wrote: > I might rather see the switch refactored to an if-then block, since it > has quite a bit of structure to it now. > > How about it includes all cases? --joel > On Wed, Apr 26, 2017 at 4:42 PM, Joel Sherrill wrote: > > --- > > cpukit/posix

Re: [PATCH v2 4/4] posix/src/mutexinit.c: Reorder to make priority a scoped variable

2017-04-26 Thread Gedare Bloom
I might rather see the switch refactored to an if-then block, since it has quite a bit of structure to it now. On Wed, Apr 26, 2017 at 4:42 PM, Joel Sherrill wrote: > --- > cpukit/posix/src/mutexinit.c | 41 +++-- > 1 file changed, 19 insertions(+), 22 deletio

[PATCH v2 4/4] posix/src/mutexinit.c: Reorder to make priority a scoped variable

2017-04-26 Thread Joel Sherrill
--- cpukit/posix/src/mutexinit.c | 41 +++-- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/cpukit/posix/src/mutexinit.c b/cpukit/posix/src/mutexinit.c index 47e0bcb..cdbba11 100644 --- a/cpukit/posix/src/mutexinit.c +++ b/cpukit/posix/src/mutex