Re: [PATCH v2 2/2] Adding trace documentation

2018-06-10 Thread Vidushi Vashishth
>The formatting is the Emacs default for ReST. It would be nice to maintain that format. Oh yes I will fix that. On Sun, Jun 10, 2018 at 5:56 PM, Chris Johns wrote: > > > On 10 Jun 2018, at 8:32 pm, Gedare Bloom wrote: > > > > I can't give a detailed review, but one possible problem I notice

Re: [PATCH v2 2/2] Adding trace documentation

2018-06-10 Thread Chris Johns
> On 10 Jun 2018, at 8:32 pm, Gedare Bloom wrote: > > I can't give a detailed review, but one possible problem I notice is > the line lengths. I think in the docs we also have 79/80 character > widths for lines. Please set your editor to hard-wrap at 79 or 80, and > break the long lines. (Unles

Re: [PATCH v2 2/2] Adding trace documentation

2018-06-10 Thread Gedare Bloom
I can't give a detailed review, but one possible problem I notice is the line lengths. I think in the docs we also have 79/80 character widths for lines. Please set your editor to hard-wrap at 79 or 80, and break the long lines. (Unless I'm mistaken about the line length in the doc files.) On Sun,

[PATCH v2 2/2] Adding trace documentation

2018-06-09 Thread Vidushi Vashishth
- Incorporated suggested changes (except making use case example as close to the actual output) - Added trace linker section (to be completed) - Added capture engine section - Added trace buffering and printk trace generation in introduction - Added trace examples section (to be completed) The on