Re: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers

On 19/3/21 4:49 am, Joel Sherrill wrote: > On Thu, Mar 18, 2021 at 12:33 PM Stephen Clark > wrote: > > Using 32bit types like uint32_t for pointers creates issues on 64 bit > architectures like AArch64. Replaced occurrences of these with uintptr_t, >

Re: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers

om: Joel Sherrill >> Sent: Thursday, March 18, 2021 12:50 PM >> To: Stephen Clark >> Cc: rtems-de...@rtems.org >> Subject: Re: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers >> >> >> >> After picking on Ryan, Alex, and Sebastian, you

Re: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers

tability" if needed > > > *From:* Joel Sherrill > *Sent:* Thursday, March 18, 2021 12:50 PM > *To:* Stephen Clark > *Cc:* rtems-de...@rtems.org > *Subject:* Re: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers > > > > After picking on Ryan, Alex, and Sebast

RE: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers

ntptr_t to build on 64-bit CPUs”, there still isn’t room to prepend “rtems-debugger:”. From: Joel Sherrill Sent: Thursday, March 18, 2021 12:50 PM To: Stephen Clark Cc: rtems-de...@rtems.org Subject: Re: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers After picking on Ryan, Alex, and Seba

Re: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers

After picking on Ryan, Alex, and Sebastian, you get it next. :) "Fix" or "Fixed" in the short commit message title is not useful when you browse the log of commits: https://git.rtems.org/rtems/log/ Something like "Use uint32_t not uintptr_t for portability to 64-bit CPUs" says a lot more. Think

[PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers

Using 32bit types like uint32_t for pointers creates issues on 64 bit architectures like AArch64. Replaced occurrences of these with uintptr_t, which will work for both 32 and 64 bit architectures. --- cpukit/libdebugger/rtems-debugger-server.c | 4 ++-- cpukit/libdebugger/rtems-debugger-target.c