Re: [PATCH v2 0/5] Add AArch64 support to libdl

2022-07-27 Thread Chris Johns
On 28/7/2022 6:02 am, Ryan Long wrote: > On 7/25/2022 10:48 PM, Chris Johns wrote: >> On 26/7/2022 12:06 am, Ryan Long wrote: >>> In this version of the patchset I converted the tabs to spaces in >>> rtl-mdreloc-aarch64.c. >> I think setting the loader to NULL is a bug. > > I removed it from rtl-m

Re: [PATCH v2 0/5] Add AArch64 support to libdl

2022-07-27 Thread Ryan Long
On 7/25/2022 10:48 PM, Chris Johns wrote: On 26/7/2022 12:06 am, Ryan Long wrote: In this version of the patchset I converted the tabs to spaces in rtl-mdreloc-aarch64.c. I think setting the loader to NULL is a bug. I removed it from rtl-mdreloc-arm.c, and ran dl05. It still passed. So sho

Re: [PATCH v2 0/5] Add AArch64 support to libdl

2022-07-25 Thread Chris Johns
On 26/7/2022 12:06 am, Ryan Long wrote: > In this version of the patchset I converted the tabs to spaces in > rtl-mdreloc-aarch64.c. I think setting the loader to NULL is a bug. > I didn't address some of the other issues in rtl-mdreloc-aarch64.c due to the > code being copied from rtl-mdreloc-ar

[PATCH v2 0/5] Add AArch64 support to libdl

2022-07-25 Thread Ryan Long
Hi, In this version of the patchset I converted the tabs to spaces in rtl-mdreloc-aarch64.c. I didn't address some of the other issues in rtl-mdreloc-aarch64.c due to the code being copied from rtl-mdreloc-arm.c. I can pull out the shared code from the two files in a follow up patch. Thanks, Rya