Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-05 Thread Joel Sherrill
On Tue, Jun 5, 2018, 10:21 PM Chris Johns wrote: > On 1/6/18 9:13 am, Joel Sherrill wrote: > > Just chatted with Chris. The coverage BSP ini file was a temporary > > measure as I thought. > > I may have not understood the specific issue being discussed when we > talked. > > I separated the INI fi

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-05 Thread Chris Johns
On 1/6/18 9:13 am, Joel Sherrill wrote: > Just chatted with Chris. The coverage BSP ini file was a temporary > measure as I thought. I may have not understood the specific issue being discussed when we talked. I separated the INI files because this is what we do else where (see the leon3 example

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Cillian O'Donnell
On Mon, 4 Jun 2018, 21:20 Vijay Kumar Banerjee, wrote: > On 5 June 2018 at 01:28, Cillian O'Donnell wrote: > >> >> >> On 4 June 2018 at 20:29, Vijay Kumar Banerjee >> wrote: >> >>> On 5 June 2018 at 00:51, Joel Sherrill wrote: >>> On Mon, Jun 4, 2018 at 2:12 PM, Vijay Kumar Bane

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Vijay Kumar Banerjee
On 5 June 2018 at 01:28, Cillian O'Donnell wrote: > > > On 4 June 2018 at 20:29, Vijay Kumar Banerjee > wrote: > >> On 5 June 2018 at 00:51, Joel Sherrill wrote: >> >>> >>> >>> On Mon, Jun 4, 2018 at 2:12 PM, Vijay Kumar Banerjee < >>> vijaykumar9...@gmail.com> wrote: >>> On 5 June 2018 at

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Cillian O'Donnell
On 4 June 2018 at 20:29, Vijay Kumar Banerjee wrote: > On 5 June 2018 at 00:51, Joel Sherrill wrote: > >> >> >> On Mon, Jun 4, 2018 at 2:12 PM, Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> On 5 June 2018 at 00:31, Joel Sherrill wrote: >>> I will add that covoar was ori

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Joel Sherrill
On Mon, Jun 4, 2018 at 2:29 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 5 June 2018 at 00:51, Joel Sherrill wrote: > >> >> >> On Mon, Jun 4, 2018 at 2:12 PM, Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> On 5 June 2018 at 00:31, Joel Sherrill wrote: >>> >

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Vijay Kumar Banerjee
On 5 June 2018 at 00:51, Joel Sherrill wrote: > > > On Mon, Jun 4, 2018 at 2:12 PM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 5 June 2018 at 00:31, Joel Sherrill wrote: >> >>> I will add that covoar was originally designed to generate a report on >>> one >>> set at a time

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Joel Sherrill
On Mon, Jun 4, 2018 at 2:12 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 5 June 2018 at 00:31, Joel Sherrill wrote: > >> I will add that covoar was originally designed to generate a report on one >> set at a time. The iteration over symbol sets was done at the scripting >> lev

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Vijay Kumar Banerjee
On 5 June 2018 at 00:31, Joel Sherrill wrote: > I will add that covoar was originally designed to generate a report on one > set at a time. The iteration over symbol sets was done at the scripting > level above that. > > This had the advantage of being simple at the time. It may still be simple >

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Joel Sherrill
I will add that covoar was originally designed to generate a report on one set at a time. The iteration over symbol sets was done at the scripting level above that. This had the advantage of being simple at the time. It may still be simple but moving the iteration over sets to covoar will probably

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Cillian O'Donnell
On 4 June 2018 at 19:03, Vijay Kumar Banerjee wrote: > On 2 June 2018 at 01:00, Vijay Kumar Banerjee > wrote: > >> On 2 June 2018 at 00:48, Joel Sherrill wrote: >> >>> >>> >>> On Fri, Jun 1, 2018, 11:21 AM Vijay Kumar Banerjee < >>> vijaykumar9...@gmail.com> wrote: >>> On 1 June 2018 at 20

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-04 Thread Vijay Kumar Banerjee
On 2 June 2018 at 01:00, Vijay Kumar Banerjee wrote: > On 2 June 2018 at 00:48, Joel Sherrill wrote: > >> >> >> On Fri, Jun 1, 2018, 11:21 AM Vijay Kumar Banerjee < >> vijaykumar9...@gmail.com> wrote: >> >>> On 1 June 2018 at 20:30, Gedare Bloom wrote: >>> On Fri, Jun 1, 2018 at 10:28 AM,

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-01 Thread Vijay Kumar Banerjee
On 2 June 2018 at 00:48, Joel Sherrill wrote: > > > On Fri, Jun 1, 2018, 11:21 AM Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 1 June 2018 at 20:30, Gedare Bloom wrote: >> >>> On Fri, Jun 1, 2018 at 10:28 AM, Vijay Kumar Banerjee >>> wrote: >>> > On 1 June 2018 at 19:24, Jo

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-01 Thread Joel Sherrill
On Fri, Jun 1, 2018, 11:21 AM Vijay Kumar Banerjee wrote: > On 1 June 2018 at 20:30, Gedare Bloom wrote: > >> On Fri, Jun 1, 2018 at 10:28 AM, Vijay Kumar Banerjee >> wrote: >> > On 1 June 2018 at 19:24, Joel Sherrill wrote: >> >> >> >> >> >> >> >> On Fri, Jun 1, 2018 at 2:46 AM, Vijay Kumar B

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-01 Thread Vijay Kumar Banerjee
On 1 June 2018 at 20:30, Gedare Bloom wrote: > On Fri, Jun 1, 2018 at 10:28 AM, Vijay Kumar Banerjee > wrote: > > On 1 June 2018 at 19:24, Joel Sherrill wrote: > >> > >> > >> > >> On Fri, Jun 1, 2018 at 2:46 AM, Vijay Kumar Banerjee > >> wrote: > >>> > >>> Here's the list of Ideas for improvem

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-01 Thread Gedare Bloom
On Fri, Jun 1, 2018 at 10:28 AM, Vijay Kumar Banerjee wrote: > On 1 June 2018 at 19:24, Joel Sherrill wrote: >> >> >> >> On Fri, Jun 1, 2018 at 2:46 AM, Vijay Kumar Banerjee >> wrote: >>> >>> Here's the list of Ideas for improvements: >>> >>> 1. Include the section coverage in the bsp config fil

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-01 Thread Vijay Kumar Banerjee
On 1 June 2018 at 19:24, Joel Sherrill wrote: > > > On Fri, Jun 1, 2018 at 2:46 AM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> Here's the list of Ideas for improvements: >> >> 1. Include the section coverage in the bsp config file. >> If the section is not found then the s

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-01 Thread Joel Sherrill
On Fri, Jun 1, 2018 at 2:46 AM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > Here's the list of Ideas for improvements: > > 1. Include the section coverage in the bsp config file. > If the section is not found then the script will show > proper error showing coverage is not su

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-06-01 Thread Vijay Kumar Banerjee
Here's the list of Ideas for improvements: 1. Include the section coverage in the bsp config file. If the section is not found then the script will show proper error showing coverage is not supported for the provided bsp config file. 2. Update covoar to add support for separate covera

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Joel Sherrill
Just chatted with Chris. The coverage BSP ini file was a temporary measure as I thought. Make a list of all the ideas we have had for improvements. We want the code to get onto master. The list should be converted to Trac tickets very soon. Then we can decide which are critical for GSoC, which Ch

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Vijay Kumar Banerjee
On Fri, 1 Jun 2018, 03:40 Joel Sherrill, wrote: > > > On Thu, May 31, 2018 at 4:57 PM, Vijay Kumar Banerjee < > vijaykumar9...@gmail.com> wrote: > >> On 1 June 2018 at 02:50, Joel Sherrill wrote: >> >>> >>> >>> On Thu, May 31, 2018 at 4:15 PM, Cillian O'Donnell < >>> cpodonne...@gmail.com> wrote

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Joel Sherrill
On Thu, May 31, 2018 at 4:57 PM, Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > On 1 June 2018 at 02:50, Joel Sherrill wrote: > >> >> >> On Thu, May 31, 2018 at 4:15 PM, Cillian O'Donnell > > wrote: >> >>> >>> >>> On Thu, 31 May 2018, 22:03 Vijay Kumar Banerjee, < >>> vijaykumar9...@gm

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Vijay Kumar Banerjee
On 1 June 2018 at 02:50, Joel Sherrill wrote: > > > On Thu, May 31, 2018 at 4:15 PM, Cillian O'Donnell > wrote: > >> >> >> On Thu, 31 May 2018, 22:03 Vijay Kumar Banerjee, < >> vijaykumar9...@gmail.com> wrote: >> >>> On 1 June 2018 at 02:14, Cillian O'Donnell >>> wrote: >>> There is now a

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Joel Sherrill
On Thu, May 31, 2018 at 4:15 PM, Cillian O'Donnell wrote: > > > On Thu, 31 May 2018, 22:03 Vijay Kumar Banerjee, > wrote: > >> On 1 June 2018 at 02:14, Cillian O'Donnell wrote: >> >>> There is now a seperate bsp config for coverage, leon3-qemu-cov. That is >>> enough to trigger coverage now and

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Cillian O'Donnell
On Thu, 31 May 2018, 22:03 Vijay Kumar Banerjee, wrote: > On 1 June 2018 at 02:14, Cillian O'Donnell wrote: > >> There is now a seperate bsp config for coverage, leon3-qemu-cov. That is >> enough to trigger coverage now and --coverage could be reserved for picking >> sets, probably renamed to --

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Vijay Kumar Banerjee
On 1 June 2018 at 02:15, Gedare Bloom wrote: > On Thu, May 31, 2018 at 4:44 PM, Cillian O'Donnell > wrote: > > There is now a seperate bsp config for coverage, leon3-qemu-cov. That is > > enough to trigger coverage now and --coverage could be reserved for > picking > > sets, probably renamed to

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Vijay Kumar Banerjee
On 1 June 2018 at 02:14, Cillian O'Donnell wrote: > There is now a seperate bsp config for coverage, leon3-qemu-cov. That is > enough to trigger coverage now and --coverage could be reserved for picking > sets, probably renamed to --coverage-sets=... Or require sets to be chosen > --coverage-sets

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Gedare Bloom
On Thu, May 31, 2018 at 4:44 PM, Cillian O'Donnell wrote: > There is now a seperate bsp config for coverage, leon3-qemu-cov. That is > enough to trigger coverage now and --coverage could be reserved for picking > sets, probably renamed to --coverage-sets=... Or require sets to be chosen > --covera

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Cillian O'Donnell
There is now a seperate bsp config for coverage, leon3-qemu-cov. That is enough to trigger coverage now and --coverage could be reserved for picking sets, probably renamed to --coverage-sets=... Or require sets to be chosen --coverage-sets=all or specific sets --coverage-sets=score,sapi,core On Th

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Vijay Kumar Banerjee
On 1 June 2018 at 01:57, Cillian O'Donnell wrote: > So is it checking whether it's --coverage or --coverage=set1,set2? Are > those the 2 possibilities your checking? > > Yes, right. :) > On Thu, 31 May 2018, 20:52 Vijay Kumar Banerjee, > wrote: > >> On 1 June 2018 at 01:19, Gedare Bloom wrote:

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Cillian O'Donnell
So is it checking whether it's --coverage or --coverage=set1,set2? Are those the 2 possibilities your checking? On Thu, 31 May 2018, 20:52 Vijay Kumar Banerjee, wrote: > On 1 June 2018 at 01:19, Gedare Bloom wrote: > >> On Thu, May 31, 2018 at 3:47 PM, Vijay Kumar Banerjee >> wrote: >> > On 1

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Vijay Kumar Banerjee
On 1 June 2018 at 01:19, Gedare Bloom wrote: > On Thu, May 31, 2018 at 3:47 PM, Vijay Kumar Banerjee > wrote: > > On 1 June 2018 at 01:07, Cillian O'Donnell > wrote: > >> > >> > >> > >> On 31 May 2018 at 19:07, Vijay Kumar Banerjee > > >> wrote: > >>> > >>> Add support in tester to run covoar

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Gedare Bloom
On Thu, May 31, 2018 at 3:47 PM, Vijay Kumar Banerjee wrote: > On 1 June 2018 at 01:07, Cillian O'Donnell wrote: >> >> >> >> On 31 May 2018 at 19:07, Vijay Kumar Banerjee >> wrote: >>> >>> Add support in tester to run covoar and generate an html report to >>> display >>> the summary of the cover

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Vijay Kumar Banerjee
On 1 June 2018 at 01:07, Cillian O'Donnell wrote: > > > On 31 May 2018 at 19:07, Vijay Kumar Banerjee > wrote: > >> Add support in tester to run covoar and generate an html report to display >> the summary of the coverage reports generated from covoar. >> >> Co-authored-by : Cillian O'Donnell >

Re: [PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Cillian O'Donnell
On 31 May 2018 at 19:07, Vijay Kumar Banerjee wrote: > Add support in tester to run covoar and generate an html report to display > the summary of the coverage reports generated from covoar. > > Co-authored-by : Cillian O'Donnell > --- > tester/rt/coverage.py | 379 > +++

[PATCH v2] tester: Add script to generate html coverage report from covoar output

2018-05-31 Thread Vijay Kumar Banerjee
Add support in tester to run covoar and generate an html report to display the summary of the coverage reports generated from covoar. Co-authored-by : Cillian O'Donnell --- tester/rt/coverage.py | 379 ++ tester/rt/test.py