Re: [PATCH v2] tester: Add basic support to generate JUnit test reports

2019-11-21 Thread Hesham Almatary
Hi Chris, Thanks for your comments. I basically duplicated the code from generate_json_report. I'll submit another version of the patch addressing your comments. On Wed, 20 Nov 2019 at 22:34, Chris Johns wrote: > > Looks good and thanks. There are some very minor formatting things, please > pus

Re: [PATCH v2] tester: Add basic support to generate JUnit test reports

2019-11-20 Thread Chris Johns
Looks good and thanks. There are some very minor formatting things, please push with these fixed. On 21/11/19 3:57 am, Hesham Almatary wrote: > --- > tester/rt/test.py | 52 ++- > 1 file changed, 51 insertions(+), 1 deletion(-) > > diff --git a/tester/

[PATCH v2] tester: Add basic support to generate JUnit test reports

2019-11-20 Thread Hesham Almatary
--- tester/rt/test.py | 52 ++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/tester/rt/test.py b/tester/rt/test.py index 3cd9b48..fded48c 100644 --- a/tester/rt/test.py +++ b/tester/rt/test.py @@ -285,8 +285,58 @@ def generate_json_repor