Re: [PATCH v2] covoar: Store address-to-line info outside of DWARF

2021-06-17 Thread Chris Johns
On 17/6/21 1:01 pm, Alex White wrote: > So is this ok to push now that it is known to have an insignificant > performance > impact or is a different approach still warranted? OK to push. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.o

Re: [PATCH v2] covoar: Store address-to-line info outside of DWARF

2021-06-16 Thread Alex White
On Mon, Jun 7, 2021 at 8:14 PM Chris Johns wrote: > > On 8/6/21 1:44 am, Joel Sherrill wrote: > > > > > > On Mon, Jun 7, 2021 at 7:00 AM Alex White > > wrote: > > > > > > On Wed, Jun 2, 2021 at 7:37 PM Chris Johns > > wrote: > >

Re: [PATCH v2] covoar: Store address-to-line info outside of DWARF

2021-06-07 Thread Chris Johns
On 8/6/21 1:44 am, Joel Sherrill wrote: > > > On Mon, Jun 7, 2021 at 7:00 AM Alex White > wrote: > > > On Wed, Jun 2, 2021 at 7:37 PM Chris Johns > wrote: > > > > Looking good with a single comment below ... > > >

Re: [PATCH v2] covoar: Store address-to-line info outside of DWARF

2021-06-07 Thread Joel Sherrill
On Mon, Jun 7, 2021 at 7:00 AM Alex White wrote: > > On Wed, Jun 2, 2021 at 7:37 PM Chris Johns wrote: > > > > Looking good with a single comment below ... > > > > On 3/6/21 6:08 am, Alex White wrote: > > > This adds the AddressToLineMapper class and supporting classes to > > > assume responsibi

Re: [PATCH v2] covoar: Store address-to-line info outside of DWARF

2021-06-07 Thread Alex White
On Wed, Jun 2, 2021 at 7:37 PM Chris Johns wrote: > > Looking good with a single comment below ... > > On 3/6/21 6:08 am, Alex White wrote: > > This adds the AddressToLineMapper class and supporting classes to > > assume responsibility of tracking address-to-line information. > > > > This allows

Re: [PATCH v2] covoar: Store address-to-line info outside of DWARF

2021-06-02 Thread Chris Johns
Looking good with a single comment below ... On 3/6/21 6:08 am, Alex White wrote: > This adds the AddressToLineMapper class and supporting classes to > assume responsibility of tracking address-to-line information. > > This allows the DWARF library to properly cleanup all of its resources > and l

[PATCH v2] covoar: Store address-to-line info outside of DWARF

2021-06-02 Thread Alex White
This adds the AddressToLineMapper class and supporting classes to assume responsibility of tracking address-to-line information. This allows the DWARF library to properly cleanup all of its resources and leads to significant memory savings. Closes #4383 --- rtemstoolkit/rld-dwarf.cpp |