Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-05 Thread Gedare Bloom
On Thu, Aug 5, 2021 at 8:56 AM zack leung wrote: > > Here you could add an assert that ptimer->clock_type == > CLOCK_MONOTONIC || ptimer->clock_type == CLOCK_REALTIME. > > Would I need to assert that the timer is not a valid timer type? Also In > psxtimer create I check if the timer is invalid.

Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-05 Thread zack leung
Here you could add an assert that ptimer->clock_type == CLOCK_MONOTONIC || ptimer->clock_type == CLOCK_REALTIME. Would I need to assert that the timer is not a valid timer type? Also In psxtimer create I check if the timer is invalid. I can do a similar if statement as I did in psxtimercreate i

Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-04 Thread Gedare Bloom
On Wed, Jul 28, 2021 at 6:28 PM Zacchaeus Leung wrote: > > the timer_create() method can use CLOCK_MONOTONIC but there was no test for > this > > Closes #3888 > --- > cpukit/include/rtems/posix/timer.h| 1 + > cpukit/posix/src/psxtimercreate.c | 3 +- > cpukit/posix/src/timerg

Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-04 Thread zack leung
bump On Thu, 29 Jul 2021 at 00:28, Zacchaeus Leung wrote: > the timer_create() method can use CLOCK_MONOTONIC but there was no test > for this > > Closes #3888 > --- > cpukit/include/rtems/posix/timer.h| 1 + > cpukit/posix/src/psxtimercreate.c | 3 +- > cpukit/posix/src/time

[PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

2021-07-28 Thread Zacchaeus Leung
the timer_create() method can use CLOCK_MONOTONIC but there was no test for this Closes #3888 --- cpukit/include/rtems/posix/timer.h| 1 + cpukit/posix/src/psxtimercreate.c | 3 +- cpukit/posix/src/timergettime.c | 52 ++- testsuites/psxtests/psxt