Re: [PATCH v2] Raspberrypi: updated the console interface.

2020-01-21 Thread Christian Mauderer
Hello Niteesh, yes, sorry. At work I only put a limited time to the mailing list as long as the patches are not work related and privately I'm currently quite busy with another project (will be better after 01.02.). Therefore I didn't have a look yet. I'll take a look at the patches. I think there

Re: [PATCH v2] Raspberrypi: updated the console interface.

2020-01-21 Thread Niteesh
I have sent a new patch for the AUX UART driver, can you please take a look at it? https://www.mail-archive.com/devel@rtems.org/msg21615.html https://www.mail-archive.com/devel@rtems.org/msg21614.html On Tue, Jan 21, 2020 at 2:42 PM Christian Mauderer < christian.maude...@embedded-brains.de> wrot

Re: [PATCH v2] Raspberrypi: updated the console interface.

2020-01-21 Thread Christian Mauderer
On 21/01/2020 00:33, Chris Johns wrote: > On 29/12/19 8:03 pm, Christian Mauderer wrote: >> - You can use a real hardware debugger for it. That's what I currently >> do - also qemu + gdb could be more powerfull. For that you basically >> connect the Alt4 pins (see https://pinout.xyz/pinout/jtag) to

Re: [PATCH v2] Raspberrypi: updated the console interface.

2020-01-20 Thread Chris Johns
On 29/12/19 8:03 pm, Christian Mauderer wrote: > - You can use a real hardware debugger for it. That's what I currently > do - also qemu + gdb could be more powerfull. For that you basically > connect the Alt4 pins (see https://pinout.xyz/pinout/jtag) to a hardware > debugger (something supported b

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-29 Thread Christian Mauderer
On 29/12/2019 15:23, Niteesh wrote: > Where does qemu place the dtb file? we can pass the dtb file to the kernel > using -dtb, but not sure where it puts it? googled a lot but couldn't > find it. I'm not really sure where qemu places a dtb. Maybe it helps if I describe roughly how it would work no

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-29 Thread Niteesh
Where does qemu place the dtb file? we can pass the dtb file to the kernel using -dtb, but not sure where it puts it? googled a lot but couldn't find it. I also tried running u-boot, it successfully ran on raspi3 in 64bit mode. I couldn't get it running on raspi2. The qemu raspi3 doesn't support n

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-29 Thread Christian Mauderer
On 29/12/2019 11:04, Niteesh wrote: > On Sun, Dec 29, 2019 at 2:33 PM Christian Mauderer > wrote: > > On 29/12/2019 07:09, Niteesh wrote: > > Is there any way to test and debug this? Maybe using GDB to > > see if a proper node is getting selected or not? >

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-29 Thread Christian Mauderer
On 29/12/2019 07:09, Niteesh wrote: > Is there any way to test and debug this? Maybe using GDB to > see if a proper node is getting selected or not? Without a debugger debugging code that is started before the console is initialized is always a bit hard. - You can try to use your qemu setup. Most

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Christian Mauderer
On 28/12/2019 20:03, Niteesh wrote: > I will start working on a patch that uses FDT. Instead of merging this > I create a patch v3 that uses FDT. Shall I remove some files, I will be > heavily using > the imx and other FDT based drivers as a reference. You can remove everything that is no longer u

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Niteesh
I will start working on a patch that uses FDT. Instead of merging this I create a patch v3 that uses FDT. Shall I remove some files, I will be heavily using the imx and other FDT based drivers as a reference. On Sun, Dec 29, 2019 at 12:27 AM Christian Mauderer wrote: > On 28/12/2019 19:48, Nitee

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Christian Mauderer
On 28/12/2019 19:48, Niteesh wrote: > Is bsp_console_select legacy? And the new way will be by linking > the correct serial device to /dev/console in console_initialization, right? > If so, shall I add one? The function is only called from legacy-console.c. So yes: This function can be removed. Th

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Christian Mauderer
On 28/12/2019 19:20, Niteesh wrote: > I am sorry if this question sounds silly, but how can I access the > output_char_fb if it > is marked as static in console-select.c, currently the fb context is in > console-config.c > Should I move the BSP_select_function to console-config? for shall I > remov

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Niteesh
Is bsp_console_select legacy? And the new way will be by linking the correct serial device to /dev/console in console_initialization, right? If so, shall I add one? On Sat, Dec 28, 2019 at 11:50 PM Niteesh wrote: > I am sorry if this question sounds silly, but how can I access the > output_char_

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Niteesh
I am sorry if this question sounds silly, but how can I access the output_char_fb if it is marked as static in console-select.c, currently the fb context is in console-config.c Should I move the BSP_select_function to console-config? for shall I remove the static qualifier from the function? Curre

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Niteesh
On Sat, Dec 28, 2019 at 11:12 PM Christian Mauderer wrote: > On 28/12/2019 17:22, Niteesh wrote: > > I think you misunderstood, I was talking about the casting in the > > rtems_termios_device_handler > > Yes, I misunderstood you there. > > > const rtems_termios_device_handler fbcons_fns = > > { >

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Christian Mauderer
On 28/12/2019 17:22, Niteesh wrote: > I think you misunderstood, I was talking about the casting in the > rtems_termios_device_handler Yes, I misunderstood you there. > const rtems_termios_device_handler fbcons_fns = > { >   .first_open = fbcons_open, >   .last_close = fbcons_close, >   .poll_rea

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Niteesh
I think you misunderstood, I was talking about the casting in the rtems_termios_device_handler const rtems_termios_device_handler fbcons_fns = { .first_open = fbcons_open, .last_close = fbcons_close, .poll_read = fbcons_inbyte_nonblocking_polled, .write = (void (*)(rtems_termios_device_cont

Re: [PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread Christian Mauderer
On 28/12/2019 14:10, G S Niteesh wrote: > The patch updates the older console interface used by the BSP, > to newer one. It also replaces the custom usart(PL011) driver > with arm-pl011. The fb function's signatures where also changed > to accommodate with interface update. > Update #3034 > --- >

[PATCH v2] Raspberrypi: updated the console interface.

2019-12-28 Thread G S Niteesh
The patch updates the older console interface used by the BSP, to newer one. It also replaces the custom usart(PL011) driver with arm-pl011. The fb function's signatures where also changed to accommodate with interface update. Update #3034 --- bsps/arm/raspberrypi/console/console-config.c | 62 ++