Re: [PATCH v2] Comment added

2019-06-17 Thread Sebastian Huber
On 17/06/2019 13:36, Sebastian Huber wrote: > +    offset_s = 1421703448;     What is this for an offset? This offset is a difference between the beginning of clock and the actual start of the clock. The event will be recorded just after the offset. Sorry, I don't know what this mean

Re: [PATCH v2] Comment added

2019-06-17 Thread Sebastian Huber
On 17/06/2019 14:41, Chris Johns wrote: On 17/6/19 8:50 pm, Ravindra Kumar Meena wrote: I wonder if there should be a top level trace directory to gather all the trace pieces in one place. I think trace is important enough to have this status. So this file could be ...  t

Re: [PATCH v2] Comment added

2019-06-17 Thread Chris Johns
On 17/6/19 8:50 pm, Ravindra Kumar Meena wrote: > > I wonder if there should be a top level trace directory to gather all the > trace > pieces in one place. I think trace is important enough to have this > status. So > this file could be ... > >  trace/config/ctf/record-ctf.ref

Re: [PATCH v2] Comment added

2019-06-17 Thread Sebastian Huber
On 17/06/2019 12:45, Ravindra Kumar Meena wrote: On Mon, Jun 17, 2019 at 1:45 PM Sebastian Huber > wrote: On 16/06/2019 20:13, Ravindra Meena wrote: > --- >   misc/CTF/record-ctf.ref | 55 +--

Re: [PATCH v2] Comment added

2019-06-17 Thread Ravindra Kumar Meena
> > > misc/CTF/record-ctf.ref | 55 > + > > We should avoid uppercase or mix case in file names unless they are > existing or > in imported code. We have some hosts that are case insensitive and our > experience over the years is this can cause proble

Re: [PATCH v2] Comment added

2019-06-17 Thread Ravindra Kumar Meena
On Mon, Jun 17, 2019 at 1:45 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 16/06/2019 20:13, Ravindra Meena wrote: > > --- > > misc/CTF/record-ctf.ref | 55 > + > > 1 file changed, 37 insertions(+), 18 deletions(-) > > > > d

Re: [PATCH v2] Comment added

2019-06-17 Thread Sebastian Huber
On 16/06/2019 20:13, Ravindra Meena wrote: --- misc/CTF/record-ctf.ref | 55 + 1 file changed, 37 insertions(+), 18 deletions(-) diff --git a/misc/CTF/record-ctf.ref b/misc/CTF/record-ctf.ref index a27757c..bdb9648 100644 --- a/misc/CTF/record-c

Re: [PATCH v2] Comment added

2019-06-16 Thread Chris Johns
On 17/6/19 4:13 am, Ravindra Meena wrote: > --- > misc/CTF/record-ctf.ref | 55 > + We should avoid uppercase or mix case in file names unless they are existing or in imported code. We have some hosts that are case insensitive and our experience ove

[PATCH v2] Comment added

2019-06-16 Thread Ravindra Meena
--- misc/CTF/record-ctf.ref | 55 + 1 file changed, 37 insertions(+), 18 deletions(-) diff --git a/misc/CTF/record-ctf.ref b/misc/CTF/record-ctf.ref index a27757c..bdb9648 100644 --- a/misc/CTF/record-ctf.ref +++ b/misc/CTF/record-ctf.ref @@ -1,5 +1