On Sat, Apr 4, 2020, 1:01 AM Gedare Bloom wrote:
> On Fri, Apr 3, 2020 at 1:11 PM Vaibhav Gupta
> wrote:
> >
> > IMO we should have a rule for nested CPP directives.
> > And also the commenting. It makes the code more readable
> > as a part of good coding style.
> >
> > Specially if the directiv
On Fri, Apr 3, 2020 at 1:11 PM Vaibhav Gupta wrote:
>
> IMO we should have a rule for nested CPP directives.
> And also the commenting. It makes the code more readable
> as a part of good coding style.
>
> Specially if the directives are nested, because they don't
> use brackets, too many opening-
IMO we should have a rule for nested CPP directives.
And also the commenting. It makes the code more readable
as a part of good coding style.
Specially if the directives are nested, because they don't
use brackets, too many opening-closing pair can make
the code hard to read.
-- Vaibhav Gupta
___
> Good advice,
Thanks!
> although I'm not sure if we have these 2 things in our
> conventions yet: nesting CPP conditional blocks, and comments on CPP
> conditional blocks?
>
Well in that case I guess Eshan should re-work on patch and also
make changes in wiki.
-- Vaibhav Gupta
___
On Fri, Apr 3, 2020 at 12:54 PM Gedare Bloom wrote:
>
> On Fri, Apr 3, 2020 at 12:35 PM Vaibhav Gupta
> wrote:
> >
> > On Fri, 27 Mar 2020 at 22:35, Eshan dhawan wrote:
> > >
> > > ---
> > > testsuites/psxtests/psxfenv01/init.c| 88 -
> > > testsuites/psxtests/psxfe
On Fri, Apr 3, 2020 at 12:35 PM Vaibhav Gupta wrote:
>
> On Fri, 27 Mar 2020 at 22:35, Eshan dhawan wrote:
> >
> > ---
> > testsuites/psxtests/psxfenv01/init.c| 88 -
> > testsuites/psxtests/psxfenv01/psxfenv01.doc | 9 ++-
> > testsuites/psxtests/psxfenv01/psxfenv01
On Fri, 27 Mar 2020 at 22:35, Eshan dhawan wrote:
>
> ---
> testsuites/psxtests/psxfenv01/init.c| 88 -
> testsuites/psxtests/psxfenv01/psxfenv01.doc | 9 ++-
> testsuites/psxtests/psxfenv01/psxfenv01.scn | 4 -
> 3 files changed, 76 insertions(+), 25 deletions(-)
>
Hello everyone,
I have added all the changes as recommended by everyone.
does anything require to be changed?
Or could it be merged now?
:)
On Fri, Mar 27, 2020 at 10:35 PM Eshan dhawan
wrote:
> ---
> testsuites/psxtests/psxfenv01/init.c| 88 -
> testsuites/psxtests
---
testsuites/psxtests/psxfenv01/init.c| 88 -
testsuites/psxtests/psxfenv01/psxfenv01.doc | 9 ++-
testsuites/psxtests/psxfenv01/psxfenv01.scn | 4 -
3 files changed, 76 insertions(+), 25 deletions(-)
diff --git a/testsuites/psxtests/psxfenv01/init.c
b/testsuites/
