Re: [PATCH rtems6 1/1] libmisc/shell: Fix timeout in getting terminal size

2024-01-24 Thread Peter Dufault
> On Jan 23, 2024, at 7:09 PM, Chris Johns wrote: > > On 23/1/2024 9:00 pm, Peter Dufault wrote: >>> On Jan 22, 2024, at 1:51 PM, Peter Dufault wrote: On Jan 22, 2024, at 12:16 PM, Gedare Bloom wrote: I have a couple minor notes below. More important, does this change req

Re: [PATCH rtems6 1/1] libmisc/shell: Fix timeout in getting terminal size

2024-01-23 Thread Chris Johns
On 23/1/2024 9:00 pm, Peter Dufault wrote: >> On Jan 22, 2024, at 1:51 PM, Peter Dufault wrote: >>> On Jan 22, 2024, at 12:16 PM, Gedare Bloom wrote: >>> >>> I have a couple minor notes below. More important, does this change >>> require updating documentation? >> >> I'd have to look to see if th

Re: [PATCH rtems6 1/1] libmisc/shell: Fix timeout in getting terminal size

2024-01-23 Thread Peter Dufault
> On Jan 22, 2024, at 1:51 PM, Peter Dufault wrote: > > > >> On Jan 22, 2024, at 12:16 PM, Gedare Bloom wrote: >> >> I have a couple minor notes below. More important, does this change >> require updating documentation? > > I'd have to look to see if this window size detection is documente

Re: [PATCH rtems6 1/1] libmisc/shell: Fix timeout in getting terminal size

2024-01-22 Thread Peter Dufault
> On Jan 22, 2024, at 12:16 PM, Gedare Bloom wrote: > > I have a couple minor notes below. More important, does this change > require updating documentation? I'd have to look to see if this window size detection is documented, I wanted to fix the problem it caused me. > > I know we have

Re: [PATCH rtems6 1/1] libmisc/shell: Fix timeout in getting terminal size

2024-01-22 Thread Gedare Bloom
I have a couple minor notes below. More important, does this change require updating documentation? I know we have a somewhat aging shell-specific guide: https://docs.rtems.org/branches/master/shell/index.html On Fri, Jan 19, 2024 at 5:19 AM wrote: > > From: Peter Dufault > > - Fix detection o

[PATCH rtems6 1/1] libmisc/shell: Fix timeout in getting terminal size

2024-01-19 Thread dufault
From: Peter Dufault - Fix detection of timeout in rtems_shell_term_wait_for(). - Switch to using "termios" VTIME inter-character timeout. The previous implementation is dependent on the BSP clock tick value. Updates #4763 --- cpukit/libmisc/shell/shell.c | 101 ++-