Re: [PATCH rtems-libbsd] regulator: Disable FDT parts for non-FDT targets

2020-04-17 Thread Christian Mauderer
On 17/04/2020 14:15, Sebastian Huber wrote: > > On 17/04/2020 14:03, Christian Mauderer wrote: >> just noted that the logic isn't entirely correct: Should it be the >> following? >> >>    #if (defined(__rtems__) && defined(FDT)) || !defined(__rtems__) >> >> The conditionals with some second define

Re: [PATCH rtems-libbsd] regulator: Disable FDT parts for non-FDT targets

2020-04-17 Thread Sebastian Huber
On 17/04/2020 14:03, Christian Mauderer wrote: just noted that the logic isn't entirely correct: Should it be the following? #if (defined(__rtems__) && defined(FDT)) || !defined(__rtems__) The conditionals with some second define are always a bit tricky in libbsd. What about #if !define

Re: [PATCH rtems-libbsd] regulator: Disable FDT parts for non-FDT targets

2020-04-17 Thread Christian Mauderer
On 17/04/2020 13:21, Sebastian Huber wrote: > Thanks, please push it. > Hello Sebastian, just noted that the logic isn't entirely correct: Should it be the following? #if (defined(__rtems__) && defined(FDT)) || !defined(__rtems__) The conditionals with some second define are always a bit tri

Re: [PATCH rtems-libbsd] regulator: Disable FDT parts for non-FDT targets

2020-04-17 Thread Sebastian Huber
Thanks, please push it. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems-libbsd] regulator: Disable FDT parts for non-FDT targets

2020-04-17 Thread Christian Mauderer
--- freebsd/sys/dev/extres/regulator/regulator.c | 2 ++ freebsd/sys/dev/gpio/gpioregulator.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/freebsd/sys/dev/extres/regulator/regulator.c b/freebsd/sys/dev/extres/regulator/regulator.c index ca2de6c4..53e45ee7 100644 --- a/freebsd/sy