Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-19 Thread Chris Johns
On 19/8/21 10:45 pm, Kinsey Moore wrote: > On 8/18/2021 18:02, Chris Johns wrote: >> On 19/8/21 5:49 am, Kinsey Moore wrote: >>> On 8/18/2021 13:20, Chris Johns wrote: On 19/8/21 3:41 am, Kinsey Moore wrote: > This is functional on the ZynqMP board I currently have setup for testing >

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-19 Thread Kinsey Moore
On 8/18/2021 18:02, Chris Johns wrote: On 19/8/21 5:49 am, Kinsey Moore wrote: On 8/18/2021 13:20, Chris Johns wrote: On 19/8/21 3:41 am, Kinsey Moore wrote: This is functional on the ZynqMP board I currently have setup for testing and on ZynqMP QEMU except for the data corruption/loss cause

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-18 Thread Chris Johns
On 19/8/21 5:49 am, Kinsey Moore wrote: > On 8/18/2021 13:20, Chris Johns wrote: >> On 19/8/21 3:41 am, Kinsey Moore wrote: >>> This is functional on the ZynqMP board I currently have setup for testing >>> and on >>> ZynqMP QEMU except for the data corruption/loss caused by the removal of the >>>

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-18 Thread Kinsey Moore
On 8/18/2021 13:20, Chris Johns wrote: On 19/8/21 3:41 am, Kinsey Moore wrote: This is functional on the ZynqMP board I currently have setup for testing and on ZynqMP QEMU except for the data corruption/loss caused by the removal of the post-baud-set null write. Thanks for the testing. I am no

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-18 Thread Chris Johns
On 19/8/21 3:41 am, Kinsey Moore wrote: > This is functional on the ZynqMP board I currently have setup for testing and > on > ZynqMP QEMU except for the data corruption/loss caused by the removal of the > post-baud-set null write. Thanks for the testing. I am not sure if you are saying both the

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-18 Thread Kinsey Moore
This is functional on the ZynqMP board I currently have setup for testing and on ZynqMP QEMU except for the data corruption/loss caused by the removal of the post-baud-set null write. Unrelated to this patch, I just realized that zynq_uart_set_attributes needs a call to zynq_uart_reset_tx_flus

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-18 Thread Chris Johns
> On 18 Aug 2021, at 4:41 pm, jan.som...@dlr.de wrote: > > Is this patch also something to backport to RTEMS5 or is this problem only > specific to the current version? I have not considered doing this as 5 works on the Zynq. If termios is the same we may look at this. And Versal is not hand

RE: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-17 Thread Jan.Sommer
de...@rtems.org > Subject: Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive > > On 17/8/21 11:21 pm, Joel Sherrill wrote: > > I'm only asking where and how did this get tested? BSPs? Qemu/HW? > Input? > > I listed the testing in the covering email ... >

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-17 Thread Chris Johns
On 17/8/21 11:21 pm, Joel Sherrill wrote: > I'm only asking where and how did this get tested? BSPs? Qemu/HW? Input? I listed the testing in the covering email ... https://lists.rtems.org/pipermail/devel/2021-August/068938.html > Long overdue. I just hope it stays fixed. I agree. Chris ___

Re: [PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-17 Thread Joel Sherrill
I'm only asking where and how did this get tested? BSPs? Qemu/HW? Input? Long overdue. I just hope it stays fixed. On Tue, Aug 17, 2021, 3:39 AM wrote: > From: Chris Johns > > - Trigger on a single character entering the RX FIFO > > - Disable the RX timeout > > - Send up to a FIFO full of data

[PATCH rtems] arm/xilinx: Fix zynq-uart interrupt receive

2021-08-17 Thread chrisj
From: Chris Johns - Trigger on a single character entering the RX FIFO - Disable the RX timeout - Send up to a FIFO full of data --- bsps/include/dev/serial/zynq-uart.h | 1 + bsps/shared/dev/serial/zynq-uart-polled.c | 18 ++- bsps/shared/dev/serial/zynq-uart.c| 66