Re: [PATCH 6/8] i386/pc386: Add --ide-disable boot command line option.

2016-05-08 Thread Gedare Bloom
On Sun, May 8, 2016 at 6:53 PM, Chris Johns wrote: > On 7/05/2016 10:48 PM, Gedare Bloom wrote: >> While you're mucking about in this code, if you can make the style >> consistent it would be good, such as to fix the opening brace on next >> line after if/for. > > If it is ok I might leave this un

Re: [PATCH 6/8] i386/pc386: Add --ide-disable boot command line option.

2016-05-08 Thread Chris Johns
On 7/05/2016 10:48 PM, Gedare Bloom wrote: > While you're mucking about in this code, if you can make the style > consistent it would be good, such as to fix the opening brace on next > line after if/for. If it is ok I might leave this until we start to add UEFI, ACPI and APIC support. A lot of co

Re: [PATCH 6/8] i386/pc386: Add --ide-disable boot command line option.

2016-05-07 Thread Gedare Bloom
While you're mucking about in this code, if you can make the style consistent it would be good, such as to fix the opening brace on next line after if/for. On Fri, May 6, 2016 at 6:23 PM, Chris Johns wrote: > --- > c/src/lib/libbsp/i386/pc386/ide/idecfg.c | 108 > ---

[PATCH 6/8] i386/pc386: Add --ide-disable boot command line option.

2016-05-06 Thread Chris Johns
--- c/src/lib/libbsp/i386/pc386/ide/idecfg.c | 108 --- 1 file changed, 57 insertions(+), 51 deletions(-) diff --git a/c/src/lib/libbsp/i386/pc386/ide/idecfg.c b/c/src/lib/libbsp/i386/pc386/ide/idecfg.c index f0f5bfe..371a6ee 100644 --- a/c/src/lib/libbsp/i386/pc386/i