Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 13:06, Chris Johns wrote: You need to be sure the build rules are as simple as you say when you start. It may pay to be more conservative and group at a lower level and then merge if you can do this. Having said this a large single file is a conflict hot spot when many people are addi

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Chris Johns
On 4/4/18 6:21 pm, Sebastian Huber wrote: > On 04/04/18 10:10, Chris Johns wrote: >> On 04/04/2018 18:03, Sebastian Huber wrote: >>> On 04/04/18 09:55, Chris Johns wrote: > I think we need only three Makefile.am and two configure.ac: > > configure.ac > Makefile.am (builds also cpuki

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 10:10, Chris Johns wrote: On 04/04/2018 18:03, Sebastian Huber wrote: On 04/04/18 09:55, Chris Johns wrote: I think we need only three Makefile.am and two configure.ac: configure.ac Makefile.am (builds also cpukit, uses AM_CONDITIONAL for cpukit/score/cpu/*) testsuites/Makefile.am

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Chris Johns
On 04/04/2018 18:07, Sebastian Huber wrote: > > Sorry, Chris. I cannot review this Autoconf/Automake stuff. I have no idea how > it works internally. I work with trial and error mostly in this domain. > Is there any other way to work with this stuff, if there is please let me know? ;) Chris __

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Chris Johns
On 04/04/2018 18:03, Sebastian Huber wrote: > On 04/04/18 09:55, Chris Johns wrote: >>> I think we need only three Makefile.am and two configure.ac: >>> >>> configure.ac >>> Makefile.am (builds also cpukit, uses AM_CONDITIONAL for cpukit/score/cpu/*) >>> testsuites/Makefile.am (uses AM_CONDITIONAL

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 09:55, Chris Johns wrote: If you can restrict yourself to just automake defined functionality you stand a chance, if you cannot you step into implementation issues. Please review the patch below. [...] An example of a breakage with the latest automake is: diff --git a/c/src/configure

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 09:55, Chris Johns wrote: I think we need only three Makefile.am and two configure.ac: configure.ac Makefile.am (builds also cpukit, uses AM_CONDITIONAL for cpukit/score/cpu/*) testsuites/Makefile.am (uses AM_CONDITIONAL for each test) 500+ tests in the one file? Really? I hope not.

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Chris Johns
On 04/04/2018 17:23, Sebastian Huber wrote: > On 04/04/18 04:23, Chris Johns wrote: >> Hi Sebastian, >> >> I do like the use of shared.am to add sources to a BSP. It hides what is >> being >> built and at this point in time I actually feel a clear view in one place is >> better than another level

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 04:23, Chris Johns wrote: Hi Sebastian, I do like the use of shared.am to add sources to a BSP. It hides what is being built and at this point in time I actually feel a clear view in one place is better than another level of indirection. Do you have more sources you wish to add this

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-03 Thread Chris Johns
Hi Sebastian, I do like the use of shared.am to add sources to a BSP. It hides what is being built and at this point in time I actually feel a clear view in one place is better than another level of indirection. Do you have more sources you wish to add this way? I sense a number of the shared BS

[PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-03 Thread Sebastian Huber
This patch is a part of the BSP source reorganization. Update #3285. Update #3375. --- c/src/support/version.c => bsps/shared/rtems-version.c | 5 - bsps/shared/shared.am | 1 + c/src/configure.ac | 2 -- c/src/support/Ma