Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

We should consider how to continue making improvements in this area of RTEMS. On Mon, Aug 24, 2015 at 1:25 PM, Rohini Kulkarni wrote: > OK, thanks all for the views. That gave plenty insight into the details I > had not thought of earlier. Clearly not the way to go. > > But then is such refactori

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

OK, thanks all for the views. That gave plenty insight into the details I had not thought of earlier. Clearly not the way to go. But then is such refactoring a good idea? These changes even if modified will apply only to cp15 ARM BSPs. On 24 Aug 2015 21:20, "Pavel Pisa" wrote: > Hello Chris and

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

Hello Chris and Rohini, I have returned and catching the emails flow. But please, consider that for some architectures it is critical to have MMU table runtime alterable. I.e. on RPi the actual memory division to cacheable and peripheral area is know only at runtime. It depends on user provided

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

On 15/08/2015 8:14 pm, Rohini Kulkarni wrote: > > > On Fri, Aug 14, 2015 at 12:41 PM, Rohini Kulkarni > wrote: > > > > On Fri, Aug 14, 2015 at 8:33 AM, Chris Johns > wrote: > > On 14/08/2015 7:44 am, Rohini Kulkarni wrot

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

On Fri, Aug 14, 2015 at 12:41 PM, Rohini Kulkarni wrote: > > > On Fri, Aug 14, 2015 at 8:33 AM, Chris Johns wrote: > >> On 14/08/2015 7:44 am, Rohini Kulkarni wrote: >> > --- >> > >> > -BSP_START_DATA_SECTION static const arm_cp15_start_section_config >> > -zynq_mmu_config_table[] = { >> > +BSP_

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

On Fri, Aug 14, 2015 at 8:33 AM, Chris Johns wrote: > On 14/08/2015 7:44 am, Rohini Kulkarni wrote: > > --- > > > > -BSP_START_DATA_SECTION static const arm_cp15_start_section_config > > -zynq_mmu_config_table[] = { > > +BSP_START_DATA_SECTION const arm_cp15_start_section_config > > +arm_cp15_sta

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

On 14/08/2015 7:44 am, Rohini Kulkarni wrote: > --- > > -BSP_START_DATA_SECTION static const arm_cp15_start_section_config > -zynq_mmu_config_table[] = { > +BSP_START_DATA_SECTION const arm_cp15_start_section_config > +arm_cp15_start_mmu_config_table[] = { >ARMV7_CP15_START_DEFAULT_SECTIONS,

[PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

--- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am |4 +++ .../libbsp/arm/xilinx-zynq/startup/bspstartmmu.c | 27 ++-- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am b/c/src/lib/libbsp/arm/xilinx-zynq/Makef