Re: [PATCH 3/3] bsps/shared/: Use device tree blob

2022-09-14 Thread Alan Cudmore
Hi Padmarao, Please see my inline comments below On Wed, Sep 14, 2022 at 12:51 AM wrote: > Hi Alan, > > > On Tue, 2022-09-13 at 23:57 -0400, Alan Cudmore wrote: > > > > Hi Padmarao, > > I am working on a RISC-V bsp variant for the Kendryte K210 and I am > > also using an included DTB. For my k21

Re: [PATCH 3/3] bsps/shared/: Use device tree blob

2022-09-14 Thread Alan Cudmore
Sorry for not thinking this through, but I think I have a more portable solution for handling the included DTB: 1. In bsps/shared/start/bsp-fdt.c, include the header as you had originally proposed. 2. Also bsps/shared/start/bsp-fdt.c, change bsp_fdt_get to return either &bsp_fdt_blob[0] for the u-b

Re: [PATCH 3/3] bsps/shared/: Use device tree blob

2022-09-13 Thread Alan Cudmore
Hi Padmarao, I am working on a RISC-V bsp variant for the Kendryte K210 and I am also using an included DTB. For my k210 bsp, I changed riscv/shared/start/start.S to set the address of the DTB array before calling bsp_fdt_copy. If we change start.S to handle the following three cases, we would not