good thing
>
> > Thanks for the quick response!
> >
>
> No problem. It takes a village to review patches. :)
>
> --joel
>
> > Harrison Gerber
> > hger...@uccs.edu
> > 720-288-7308
> >
> > -Original Message-
> > From: Joel Sh
t;
> -Original Message-
> From: Joel Sherrill
> Sent: Tuesday, June 29, 2021 2:09 PM
> To: Harrison Edward Gerber
> Cc: rtems-de...@rtems.org ; Harrison Gerber
>
> Subject: Re: [PATCH 2/3] cpukit/libmisc/rtems-fdt: Fixes leaked variable 'bf'
> in rtems-fdt
I'm ok with the fix but the commit message could be improved.
Something like this would be better.
cpukit/libmisc/rtems-fdt.c : close() file to avoid leaking descriptor
You almost duplicated the base file name and it isn't leaking the
variable, it is leaking the file descriptor referenced by bf.
See Also CID 1437645
Closes #4297
---
cpukit/libmisc/rtems-fdt/rtems-fdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/cpukit/libmisc/rtems-fdt/rtems-fdt.c
b/cpukit/libmisc/rtems-fdt/rtems-fdt.c
index bfbc6102a2..5580d415e2 100644
--- a/cpukit/libmisc/rtems-fdt/rtems-fdt.c
+++ b/cpukit/l
