Re: [PATCH 2/3] build: Replace variant patterns with a list

2023-01-19 Thread Sebastian Huber
On 20.01.23 00:36, Chris Johns wrote: So let me turn this around ... I am do not understand your resistance to there being importable modules of python in rtems.git to read and write these files in rtems.git? These modules are in rtems-central.git (which has rtems.git as a submodule) together

Re: [PATCH 2/3] build: Replace variant patterns with a list

2023-01-19 Thread Chris Johns
On 19/1/2023 6:06 pm, Sebastian Huber wrote: > On 19.01.23 01:17, Chris Johns wrote: Why has this been done? >>> The enabled-by expressions used in patch 3 do not support regular >>> expressions. >> I did not pick that up. Why was that regx functionality removed? Is it >> related >> to scrip

Re: [PATCH 2/3] build: Replace variant patterns with a list

2023-01-18 Thread Sebastian Huber
On 19.01.23 01:17, Chris Johns wrote: Why has this been done? The enabled-by expressions used in patch 3 do not support regular expressions. I did not pick that up. Why was that regx functionality removed? Is it related to scripting and rtems-central? The enabled-by expressions supported by t

Re: [PATCH 2/3] build: Replace variant patterns with a list

2023-01-18 Thread Chris Johns
On 18/1/2023 6:00 pm, Sebastian Huber wrote: > On 18.01.23 04:59, Chris Johns wrote: >> Hi Sebastian, >> >> I had not got to this part of the patch set because the other was being >> discussed. I thought a patch set was considerd as a whole rather than having >> to >> deal with the extra complexit

Re: [PATCH 2/3] build: Replace variant patterns with a list

2023-01-17 Thread Sebastian Huber
On 18.01.23 04:59, Chris Johns wrote: Hi Sebastian, I had not got to this part of the patch set because the other was being discussed. I thought a patch set was considerd as a whole rather than having to deal with the extra complexity of possible splits and if they exist? If this was pull reques

Re: [PATCH 2/3] build: Replace variant patterns with a list

2023-01-17 Thread Chris Johns
Hi Sebastian, I had not got to this part of the patch set because the other was being discussed. I thought a patch set was considerd as a whole rather than having to deal with the extra complexity of possible splits and if they exist? If this was pull request or merge request in a tool none of thi

[PATCH 2/3] build: Replace variant patterns with a list

2023-01-12 Thread Sebastian Huber
Replace the variant patterns in the default-by-variant list with an explicit list of matching BSPs. The change was tested by comparing the output of ./waf bspdefaults before and after the change. --- .../bsps/aarch64/xilinx-zynqmp/optclki2c0.yml | 8 +++ .../bsps/aarch64/xilinx-zynqmp/op