Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-06 Thread Sebastian Huber
On 06/05/2019 15:48, dufa...@hda.com wrote: On May 6, 2019, at 01:02 , Sebastian Huber > wrote: On 05/05/2019 03:00, Chris Johns wrote: On 5/5/19 12:21 am, Joel Sherrill wrote: Sorry for missing that it actually was referenced Rcmd can and should

[PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-06 Thread Lou Woods
From: Lou Woods rcmdsh() and innetgr() are referenced by rcmd, but aren’t available in libbsd and are unresolvable external symbols when libbsd.a is processed by the RTL. innetgr() is part of netgroup and could be ported in at some point in the future. rcmdsh() uses fork() and exec() so uses of

RE: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-06 Thread Lou Woods
half Of Joel Sherrill > Sent: Monday, May 6, 2019 9:31 AM > To: Peter Dufault > Cc: Lou Woods ; RTEMS Devel devel@rtems.org> > Subject: Re: [PATCH 2/2] rcmd.c: Removed references to unsupported > functions > > > > On Mon, May 6, 2019 at 8:49 AM <mailto:dufa...@

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-06 Thread Joel Sherrill
On Mon, May 6, 2019 at 8:49 AM wrote: > > > On May 6, 2019, at 01:02 , Sebastian Huber < > sebastian.hu...@embedded-brains.de> wrote: > > On 05/05/2019 03:00, Chris Johns wrote: > > On 5/5/19 12:21 am, Joel Sherrill wrote: > > Sorry for missing that it actually was referenced > > Rcmd can and sho

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-06 Thread dufault
> On May 6, 2019, at 01:02 , Sebastian Huber > wrote: > > On 05/05/2019 03:00, Chris Johns wrote: >> On 5/5/19 12:21 am, Joel Sherrill wrote: >>> Sorry for missing that it actually was referenced >>> >>> Rcmd can and should work. Rcmdsh will not ever and should be removed from >>> libbsd. >>

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-05 Thread Sebastian Huber
On 05/05/2019 03:00, Chris Johns wrote: On 5/5/19 12:21 am, Joel Sherrill wrote: Sorry for missing that it actually was referenced Rcmd can and should work. Rcmdsh will not ever and should be removed from libbsd. Does rcmd need testing? It clearly had no test since it wouldn't have linked.

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-04 Thread Chris Johns
On 5/5/19 12:21 am, Joel Sherrill wrote: Sorry for missing that it actually was referenced Rcmd can and should work. Rcmdsh will not ever and should be removed from libbsd. Does rcmd need testing? It clearly had no test since it wouldn't have linked. Yes that would be great. Testing libbsd

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-04 Thread Joel Sherrill
Sorry for missing that it actually was referenced Rcmd can and should work. Rcmdsh will not ever and should be removed from libbsd. Does rcmd need testing? It clearly had no test since it wouldn't have linked. --joel On Sat, May 4, 2019, 4:40 AM Peter Dufault wrote: > > > On May 4, 2019, at 0

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-04 Thread Peter Dufault
> On May 4, 2019, at 02:37 , Chris Johns wrote: > > On 4/5/19 2:30 pm, Joel Sherrill wrote: >> On Fri, May 3, 2019, 8:18 PM Chris Johns > > wrote: >>On 4/5/19 9:16 am, Joel Sherrill wrote: >> > On Fri, May 3, 2019, 6:04 PM Chris Johns >

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-03 Thread Chris Johns
On 4/5/19 2:30 pm, Joel Sherrill wrote: On Fri, May 3, 2019, 8:18 PM Chris Johns > wrote: On 4/5/19 9:16 am, Joel Sherrill wrote: > On Fri, May 3, 2019, 6:04 PM Chris Johns mailto:chr...@rtems.org> > >> wrote

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-03 Thread Joel Sherrill
On Fri, May 3, 2019, 8:18 PM Chris Johns wrote: > On 4/5/19 9:16 am, Joel Sherrill wrote: > > On Fri, May 3, 2019, 6:04 PM Chris Johns > > wrote: > > > > On 4/5/19 7:44 am, Lou Woods wrote: > > > From: Lou Woods > > > > > > rcmdsh() and innetgr() are

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-03 Thread Chris Johns
On 4/5/19 9:16 am, Joel Sherrill wrote: On Fri, May 3, 2019, 6:04 PM Chris Johns > wrote: On 4/5/19 7:44 am, Lou Woods wrote: > From: Lou Woods > > rcmdsh() and innetgr() are referenced by rcmd, but aren’t available > in libbsd and are unresolvab

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-03 Thread Joel Sherrill
On Fri, May 3, 2019, 6:04 PM Chris Johns wrote: > On 4/5/19 7:44 am, Lou Woods wrote: > > From: Lou Woods > > > > rcmdsh() and innetgr() are referenced by rcmd, but aren’t available > > in libbsd and are unresolvable external symbols when libbsd.a is > > processed by the RTL. > > Why does this n

Re: [PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-03 Thread Chris Johns
On 4/5/19 7:44 am, Lou Woods wrote: From: Lou Woods rcmdsh() and innetgr() are referenced by rcmd, but aren’t available in libbsd and are unresolvable external symbols when libbsd.a is processed by the RTL. Why does this not show up when we statically link? I wonder if this is related to sep

[PATCH 2/2] rcmd.c: Removed references to unsupported functions

2019-05-03 Thread Lou Woods
From: Lou Woods rcmdsh() and innetgr() are referenced by rcmd, but aren’t available in libbsd and are unresolvable external symbols when libbsd.a is processed by the RTL. innetgr() is part of netgroup and could be ported in at some point in the future. rcmdsh() uses fork() and exec() so uses of