Re: [PATCH 2/2] i386: doxygen and comments related to VESA real mode framebuffer

2014-12-03 Thread Gedare Bloom
On Wed, Dec 3, 2014 at 11:29 AM, Jan Dolezal wrote: > Hello Gedare, > > thank you very much for your comments. I really appreciate them. > > On 3.12.2014 00:59, Gedare Bloom wrote: >> >> Sometimes params are identified as in our out, sometimes they are not. >> Please be consistent. Generally patch

Re: [PATCH 2/2] i386: doxygen and comments related to VESA real mode framebuffer

2014-12-03 Thread Jan Dolezal
Hello Gedare, thank you very much for your comments. I really appreciate them. On 3.12.2014 00:59, Gedare Bloom wrote: Sometimes params are identified as in our out, sometimes they are not. Please be consistent. Generally patch looks OK, does the doxygen look right when applied? [1] can help Th

Re: [PATCH 2/2] i386: doxygen and comments related to VESA real mode framebuffer

2014-12-02 Thread Gedare Bloom
Sometimes params are identified as in our out, sometimes they are not. Please be consistent. Generally patch looks OK, does the doxygen look right when applied? [1] can help -Gedare [1] https://github.com/joelsherrill/gci_tasks/blob/master/2013/doxygen_c_header_tasks/validate/do_doxygen On Tue,

[PATCH 2/2] i386: doxygen and comments related to VESA real mode framebuffer

2014-12-02 Thread Jan Dolezal
--- c/src/lib/libbsp/i386/pc386/console/fb_vesa_rm.c | 105 --- c/src/lib/libbsp/i386/pc386/include/edid.h | 14 +- c/src/lib/libbsp/i386/pc386/include/fb_vesa.h | 74 ++--- c/src/lib/libbsp/i386/pc386/include/tblsizes.h | 1 - c/src/lib/libbsp/i386/pc386/include/vbe3.h