Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Sebastian Huber
On 22/04/2021 20:00, Gedare Bloom wrote: On Thu, Apr 22, 2021 at 11:33 AM Sebastian Huber wrote: On 22/04/2021 17:44, Gedare Bloom wrote: Also not related to the documentation, but it seems that rtems_message_queue_construct() will not handle a NULL configuration. Is this intentional, or a

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 11:33 AM Sebastian Huber wrote: > > On 22/04/2021 17:44, Gedare Bloom wrote: > > > Also not related to the documentation, but it seems that > > rtems_message_queue_construct() will not handle a NULL configuration. > > Is this intentional, or a bug to fix in the code and an

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 11:52 AM Sebastian Huber wrote: > > On 22/04/2021 17:44, Gedare Bloom wrote: > > >> +:c:macro:`RTEMS_ILLEGAL_ON_REMOTE_OBJECT` > >> +The semaphore resided on a remote node. > > s/semaphore/message queue > > > Thanks for the review. I fixed the typos. Should I still send

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Sebastian Huber
On 22/04/2021 17:44, Gedare Bloom wrote: +:c:macro:`RTEMS_ILLEGAL_ON_REMOTE_OBJECT` +The semaphore resided on a remote node. s/semaphore/message queue Thanks for the review. I fixed the typos. Should I still send a v2 of the patch? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Sebastian Huber
On 22/04/2021 17:44, Gedare Bloom wrote: +.. index:: RTEMS_MESSAGE_QUEUE_BUFFER() + +.. _InterfaceRTEMSMESSAGEQUEUEBUFFER: + +RTEMS_MESSAGE_QUEUE_BUFFER() Before now, this was not well documented. It is good to add, but I wonder if this is also a good time to make it more like other macro-based

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Sebastian Huber
On 22/04/2021 17:44, Gedare Bloom wrote: Also not related to the documentation, but it seems that rtems_message_queue_construct() will not handle a NULL configuration. Is this intentional, or a bug to fix in the code and an error status to add? If it is intentional, an assert(config) should be a

Re: [PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Gedare Bloom
On Thu, Apr 22, 2021 at 8:07 AM Sebastian Huber wrote: > > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files were generated

[PATCH 2/2] c-user: Generate message manager documentation

2021-04-22 Thread Sebastian Huber
The documentation is a consolidation of the comments in Doxygen markup and the documentation sources in Sphinx markup. The documentation was transfered to interface specification items. The documentation source files were generated from the items by a script. Update #3993. --- c-user/message/di