On Thu, Apr 20, 2017 at 7:41 PM, Chris Johns wrote:
> On 21/04/2017 07:52, Patrick Gauvin wrote:
>
>> Chris,
>>
>>
>> +
>> +static drvdata data;
>> +/* TODO: Abstract DMA buffer retrieval better */
>>
>>
>> Agreed.
>>
>>
>> +static uint8_t *dma_buf = NULL;
>>
On 21/04/2017 07:52, Patrick Gauvin wrote:
Chris,
+
+static drvdata data;
+/* TODO: Abstract DMA buffer retrieval better */
Agreed.
+static uint8_t *dma_buf = NULL;
+
+/* Check if bit is set in reg (and not masked by mask), and if
Chris,
>> +
>> +static drvdata data;
>> +/* TODO: Abstract DMA buffer retrieval better */
>>
>
> Agreed.
>
>
> +static uint8_t *dma_buf = NULL;
>> +
>> +/* Check if bit is set in reg (and not masked by mask), and if it is,
>> write
>> + * that bit to reg, returning true. Otherwise return false.
>
Thanks for submitting this driver. My comments are below.
Chris
On 20/04/2017 13:08, Patrick Gauvin wrote:
---
c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 +
.../libbsp/arm/xilinx-zynq/devcfg/zynq-devcfg.c| 770 +
.../arm/xilinx-zynq/include/zynq-devcfg-reg
---
c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 +
.../libbsp/arm/xilinx-zynq/devcfg/zynq-devcfg.c| 770 +
.../arm/xilinx-zynq/include/zynq-devcfg-regs.h | 194 ++
.../libbsp/arm/xilinx-zynq/include/zynq-devcfg.h | 160 +
c/src/lib/libbsp/arm/xili
