Re: [PATCH 2/2] Fix warning -Wchar-subscripts in isspace() and isdigit()

2020-08-03 Thread Gedare Bloom
On Mon, Aug 3, 2020 at 9:11 AM Aschref Ben-Thabet wrote: > > From: Aschref Ben Thabet > > The warning may be because you're passing a char to the isspace() macro. > > The implementation of isspace() may be via array indexing. > > This means that the index for the array can be negative. > > This c

Re: [PATCH 2/2] Fix warning -Wchar-subscripts in isspace() and isdigit()

2020-08-03 Thread Sebastian Huber
Hello Aschref, I think we should have a look how git rebase -i works later this week. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

[PATCH 2/2] Fix warning -Wchar-subscripts in isspace() and isdigit()

2020-08-03 Thread Aschref Ben-Thabet
From: Aschref Ben Thabet The warning may be because you're passing a char to the isspace() macro. The implementation of isspace() may be via array indexing. This means that the index for the array can be negative. This can be a problem as a char could represent a signed value, and you may be r