Re: [PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code

2017-05-14 Thread Sichen Zhao
Ok, that's very kind of you. Sichen Zhao From: Joel Sherrill Sent: Sunday, May 14, 2017 9:17 PM To: 赵 思晨 Cc: rtems-de...@rtems.org; punit vara; Christian Mauderer Subject: Re: [PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code If something

Re: [PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code

2017-05-14 Thread Joel Sherrill
> > Thank you > > Sichen Zhao > > > -- > *From:* devel on behalf of Christian Mauderer < > christian.maude...@embedded-brains.de> > *Sent:* Sunday, May 14, 2017 8:42 PM > *To:* Sichen Zhao > *Cc:* punit vara; devel@rtems.org > *Subject:* Re: [PAT

Re: [PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code

2017-05-14 Thread Sichen Zhao
: [PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code Hello Sichen Zhao, I haven't tested the code yet. But on a first look, I noted some points regarding the style: - If I apply the patches, there are a lot of "trailing whitespace" warnings - There are some // comments in the

Re: [PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code

2017-05-14 Thread Christian Mauderer
> > An: devel@rtems.org, "punit vara" , "Christian Mauderer" > > Gesendet: Samstag, 13. Mai 2017 05:52:13 > Betreff: [PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code > This patch modify the i2c code for Beaglebone Black based on PV works: >

[PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code

2017-05-12 Thread Sichen Zhao
This patch modify the i2c code for Beaglebone Black based on PV works: - bbb-i2c.c: Modify the interrupt handler, transfer funciton, read function, am335x_i2c_busbusy function etc. Add flush_fifo function - include/i2c.h: Modify some macros, such as BBB_I2C_IRQ_ERROR Now the i2c is working on Bea

[PATCH 2/2] Beagle i2c: Update Beaglebone i2c driver code

2017-03-30 Thread Sichen Zhao
This patch modify the i2c code for Beaglebone Black based on PV works: - bbb-i2c.c: Modify the interrupt handler, transfer funciton, read function, am335x_i2c_busbusy function etc. Add flush_fifo function - include/i2c.h: Modify some macros, such as BBB_I2C_IRQ_ERROR Now the i2c is working on Bea